2021-10-19 09:03:46

by Li, Meng

Subject: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default

The gpio5-pin9 is used as the interrupt pin of i2c external
gpio chip, so set this pin as input by default.

Signed-off-by: Meng Li <[email protected]>
---
arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 202177706cde..8986a7e6e099 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -205,6 +205,15 @@
};
};

+&gpio5 {
+ gpio_exp_77_int {
+ gpio-hog;
+ gpios = <9 0>;
+ input;
+ line-name = "gpio-exp-77-int";
+ };
+};
+
&i2c4 {
i2cswitch4: i2c-switch@71 {
compatible = "nxp,pca9548";
--
2.17.1

2021-10-19 14:44:06

by Kieran Bingham

Subject: Re: [PATCH] arch: arm64: dts: Set gpio5-pin9 as input by default

Quoting Meng Li (2021-10-19 10:00:20)
> The gpio5-pin9 is used as the interrupt pin of i2c external
> gpio chip, so set this pin as input by default.

Is a GPIO hog the right way to do this?
Shouldn't the other GPIO chip be modelled in DT and reference the gpio
interrupt line from there in its interrupt property?

I assume by 'external gpio chip' you mean one which is permanantly
attached to the ULCB Kingfisher board, and not a custom addition?

--
Regards
Kieran

>
> Signed-off-by: Meng Li <[email protected]>
> ---
> arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 202177706cde..8986a7e6e099 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -205,6 +205,15 @@
> };
> };
>
> +&gpio5 {
> + gpio_exp_77_int {
> + gpio-hog;
> + gpios = <9 0>;
> + input;
> + line-name = "gpio-exp-77-int";
> + };
> +};
> +
> &i2c4 {
> i2cswitch4: i2c-switch@71 {
> compatible = "nxp,pca9548";
> --
> 2.17.1
>