2021-10-29 09:55:39

by Jiapeng Chong

Subject: [PATCH] block: ataflop: Fix warning comparing pointer to 0

Fix the following coccicheck warning:

./drivers/block/ataflop.c:1464:20-21: WARNING comparing pointer to 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/block/ataflop.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index 2622803..d14bdc3 100644
--- a/drivers/block/ataflop.c
+++ b/drivers/block/ataflop.c
@@ -1460,8 +1460,7 @@ static int floppy_revalidate(struct gendisk *disk)
unsigned int drive = p - unit;

if (test_bit(drive, &changed_floppies) ||
- test_bit(drive, &fake_change) ||
- p->disktype == 0) {
+ test_bit(drive, &fake_change) || !p->disktype) {
if (UD.flags & FTD_MSG)
printk(KERN_ERR "floppy: clear format %p!\n", UDT);
BufferDrive = -1;
--
1.8.3.1

2021-10-29 13:00:46

by Jens Axboe

Subject: Re: [PATCH] block: ataflop: Fix warning comparing pointer to 0

On Fri, 29 Oct 2021 17:50:29 +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warning:
>
> ./drivers/block/ataflop.c:1464:20-21: WARNING comparing pointer to 0.
>
>

Applied, thanks!

[1/1] block: ataflop: Fix warning comparing pointer to 0
commit: df75db1fc1e5608271397de37cab43371bb838d2

Best regards,
--
Jens Axboe