Comment in function psi_task_switch,there are two same lines.
...
* runtime state, the cgroup that contains both tasks
* runtime state, the cgroup that contains both tasks
...
Signed-off-by: Liu Xinpeng <[email protected]>
---
kernel/sched/psi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 1652f2b..526af84 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
/*
* When switching between tasks that have an identical
* runtime state, the cgroup that contains both tasks
- * runtime state, the cgroup that contains both tasks
* we reach the first common ancestor. Iterate @next's
* ancestors only until we encounter @prev's ONCPU.
*/
--
1.8.3.1
On Mon, Oct 25, 2021 at 11:46:25AM +0800, Liu Xinpeng wrote:
> Comment in function psi_task_switch,there are two same lines.
> ...
> * runtime state, the cgroup that contains both tasks
> * runtime state, the cgroup that contains both tasks
> ...
>
> Signed-off-by: Liu Xinpeng <[email protected]>
Acked-by: Johannes Weiner <[email protected]>
Peter, could you please take this through -tip?
> ---
> kernel/sched/psi.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
> index 1652f2b..526af84 100644
> --- a/kernel/sched/psi.c
> +++ b/kernel/sched/psi.c
> @@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
> /*
> * When switching between tasks that have an identical
> * runtime state, the cgroup that contains both tasks
> - * runtime state, the cgroup that contains both tasks
> * we reach the first common ancestor. Iterate @next's
> * ancestors only until we encounter @prev's ONCPU.
> */
On Thu, Nov 04, 2021 at 12:49:51PM -0400, Johannes Weiner wrote:
> On Mon, Oct 25, 2021 at 11:46:25AM +0800, Liu Xinpeng wrote:
> > Comment in function psi_task_switch,there are two same lines.
> > ...
> > * runtime state, the cgroup that contains both tasks
> > * runtime state, the cgroup that contains both tasks
> > ...
> >
> > Signed-off-by: Liu Xinpeng <[email protected]>
>
> Acked-by: Johannes Weiner <[email protected]>
>
> Peter, could you please take this through -tip?
Sure, lemme figure out the b4 incantation to grab these patches since
the originals didn't make it to my inbox. They should show up in
tip/sched/core after -rc1 or so if I get the incantation right :-)
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 2d3791f116bb3d5b17571dadb8e085e12ae3a3cf
Gitweb: https://git.kernel.org/tip/2d3791f116bb3d5b17571dadb8e085e12ae3a3cf
Author: Liu Xinpeng <[email protected]>
AuthorDate: Mon, 25 Oct 2021 11:46:25 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Wed, 17 Nov 2021 14:48:59 +01:00
psi: Remove repeated verbose comment
Comment in function psi_task_switch,there are two same lines.
...
* runtime state, the cgroup that contains both tasks
* runtime state, the cgroup that contains both tasks
...
Signed-off-by: Liu Xinpeng <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Acked-by: Johannes Weiner <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/psi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/sched/psi.c b/kernel/sched/psi.c
index 1652f2b..526af84 100644
--- a/kernel/sched/psi.c
+++ b/kernel/sched/psi.c
@@ -833,7 +833,6 @@ void psi_task_switch(struct task_struct *prev, struct task_struct *next,
/*
* When switching between tasks that have an identical
* runtime state, the cgroup that contains both tasks
- * runtime state, the cgroup that contains both tasks
* we reach the first common ancestor. Iterate @next's
* ancestors only until we encounter @prev's ONCPU.
*/