2021-12-02 21:03:39

by Andy Shevchenko

Subject: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment

GPIO library does copy the of_node from the parent device of
the GPIO chip, there is no need to repeat this in the individual
drivers. Remove assignment here.

For the details one may look into the of_gpio_dev_init() implementation.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/media/i2c/max9286.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 7c663fd587bb..a662d3aa0641 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
gpio->label = dev_name(dev);
gpio->parent = dev;
gpio->owner = THIS_MODULE;
- gpio->of_node = dev->of_node;
gpio->ngpio = 2;
gpio->base = -1;
gpio->set = max9286_gpio_set;
--
2.33.0

2021-12-02 21:36:07

by Laurent Pinchart

Subject: Re: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment

Hi Andy,

Thank you for the patch.

On Thu, Dec 02, 2021 at 11:03:35PM +0200, Andy Shevchenko wrote:
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>
> For the details one may look into the of_gpio_dev_init() implementation.
>
> Signed-off-by: Andy Shevchenko <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> drivers/media/i2c/max9286.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 7c663fd587bb..a662d3aa0641 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
> gpio->label = dev_name(dev);
> gpio->parent = dev;
> gpio->owner = THIS_MODULE;
> - gpio->of_node = dev->of_node;
> gpio->ngpio = 2;
> gpio->base = -1;
> gpio->set = max9286_gpio_set;

--
Regards,

Laurent Pinchart

2021-12-03 13:09:28

by Kieran Bingham

Subject: Re: [PATCH v1 1/1] media: i2c: max9286: Get rid of duplicate of_node assignment

Quoting Andy Shevchenko (2021-12-02 21:03:35)
> GPIO library does copy the of_node from the parent device of
> the GPIO chip, there is no need to repeat this in the individual
> drivers. Remove assignment here.
>
> For the details one may look into the of_gpio_dev_init() implementation.

I see it.

Thanks,

Reviewed-by: Kieran Bingham <[email protected]>

>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/media/i2c/max9286.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
> index 7c663fd587bb..a662d3aa0641 100644
> --- a/drivers/media/i2c/max9286.c
> +++ b/drivers/media/i2c/max9286.c
> @@ -1055,7 +1055,6 @@ static int max9286_register_gpio(struct max9286_priv *priv)
> gpio->label = dev_name(dev);
> gpio->parent = dev;
> gpio->owner = THIS_MODULE;
> - gpio->of_node = dev->of_node;
> gpio->ngpio = 2;
> gpio->base = -1;
> gpio->set = max9286_gpio_set;
> --
> 2.33.0
>