2022-02-10 18:27:09

by Nitin Rawat

Subject: [PATCH v2] nvme/pci: Add quick suspend quirk for Sc7280 Platform

Enable quick suspend quirks for Sc7280 platform, where power
to nvme device is removed during suspend-resume process. This
is done to avoid the failure dring resume.

This enables simple suspend path for this platform.

Signed-off-by: Nitin Rawat <[email protected]>
Signed-off-by: Shaik Sajida Bhanu <[email protected]>
---

Change from v1-v2:

*Moving the check condition outside vendor/device check
to make this platform specific

---
drivers/nvme/host/pci.c | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
index 6a99ed6..fa25d9fab 100644
--- a/drivers/nvme/host/pci.c
+++ b/drivers/nvme/host/pci.c
@@ -3032,6 +3032,13 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) &&
dmi_match(DMI_BOARD_NAME, "LNVNB161216"))
return NVME_QUIRK_SIMPLE_SUSPEND;
+ } else if (of_machine_is_compatible("qcom,sc7280")) {
+ /*
+ * Append quick suspend quirks for sc7280 platforms
+ * so that simple suspend path is executed for this
+ * platform to avoid any resume failure.
+ */
+ return NVME_QUIRK_SIMPLE_SUSPEND;
}

return 0;
--
2.7.4

2022-02-10 20:29:41

by Keith Busch

Subject: Re: [PATCH v2] nvme/pci: Add quick suspend quirk for Sc7280 Platform

On Thu, Feb 10, 2022 at 10:25:04PM +0530, Nitin Rawat wrote:
> Enable quick suspend quirks for Sc7280 platform, where power
> to nvme device is removed during suspend-resume process. This
> is done to avoid the failure dring resume.
>
> This enables simple suspend path for this platform.
>
> Signed-off-by: Nitin Rawat <[email protected]>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> ---
>
> Change from v1-v2:
>
> *Moving the check condition outside vendor/device check
> to make this platform specific
>
> ---
> drivers/nvme/host/pci.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/nvme/host/pci.c b/drivers/nvme/host/pci.c
> index 6a99ed6..fa25d9fab 100644
> --- a/drivers/nvme/host/pci.c
> +++ b/drivers/nvme/host/pci.c
> @@ -3032,6 +3032,13 @@ static unsigned long check_vendor_combination_bug(struct pci_dev *pdev)
> if ((dmi_match(DMI_BOARD_VENDOR, "LENOVO")) &&
> dmi_match(DMI_BOARD_NAME, "LNVNB161216"))
> return NVME_QUIRK_SIMPLE_SUSPEND;
> + } else if (of_machine_is_compatible("qcom,sc7280")) {
> + /*
> + * Append quick suspend quirks for sc7280 platforms
> + * so that simple suspend path is executed for this
> + * platform to avoid any resume failure.
> + */
> + return NVME_QUIRK_SIMPLE_SUSPEND;
> }

Did you test this? Because I think you said that this is the Kioxa
controller matching the vendor:device in the previos "else if", which
means we won't reach this part.