2022-02-15 00:52:03

by NeilBrown

[permalink] [raw]
Subject: Re: [PATCH 01/21] MM: create new mm/swap.h header file.

On Fri, 11 Feb 2022, Geert Uytterhoeven wrote:
> Hi Neil,
>
> On Wed, Feb 9, 2022 at 10:52 AM NeilBrown <[email protected]> wrote:
> > Many functions declared in include/linux/swap.h are only used within mm/
> >
> > Create a new "mm/swap.h" and move some of these declarations there.
> > Remove the redundant 'extern' from the function declarations.
> >
> > Reviewed-by: Christoph Hellwig <[email protected]>
> > Signed-off-by: NeilBrown <[email protected]>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/mm/swap.h
> > @@ -0,0 +1,129 @@
> > +
>
> scripts/checkpatch.pl:
> WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
>
> Gr{oetje,eeting}s,
>
> Geert

Argg... I think you pointed that out previously and I forgot to act on
it.
I've now copied the SPDX line from linux/swap.h, and also added that
standard "#ifndef _MM_SWAP_H" etc protection.

Thanks,
NeilBrown