2022-02-15 05:25:58

by 王擎

Subject: [PATCH] spi: add missing pci_dev_put() before return

From: Wang Qing <[email protected]>

pci_get_slot() increases its reference count, the caller must
decrement the reference count by calling pci_dev_put()

Signed-off-by: Wang Qing <[email protected]>
---
drivers/spi/spi-pxa2xx-pci.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
index 2e134eb..5fb2f44
--- a/drivers/spi/spi-pxa2xx-pci.c
+++ b/drivers/spi/spi-pxa2xx-pci.c
@@ -102,6 +102,8 @@ static int lpss_spi_setup(struct pci_dev *dev, struct pxa_spi_info *c)
}

c->dma_filter = lpss_dma_filter;
+ pci_dev_put(dma_dev);
+
return 0;
}

--
2.7.4

2022-02-23 15:26:15

by Geert Uytterhoeven

Subject: Re: [PATCH] spi: add missing pci_dev_put() before return

Hi Qing,

On Tue, Feb 15, 2022 at 3:08 AM Qing Wang <[email protected]> wrote:
> From: Wang Qing <[email protected]>
>
> pci_get_slot() increases its reference count, the caller must
> decrement the reference count by calling pci_dev_put()
>
> Signed-off-by: Wang Qing <[email protected]>

Thanks for your patch!

Please use "spi: spi-topcliff-pch:" instead of just "spi:" in the patch
summary, as this is specific to the spi-topcliff-pch driver, not to the SPI
core.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2022-02-24 01:25:30

by Andy Shevchenko

Subject: Re: [PATCH] spi: add missing pci_dev_put() before return

On Tue, Feb 15, 2022 at 6:04 AM Qing Wang <[email protected]> wrote:
>
> From: Wang Qing <[email protected]>
>
> pci_get_slot() increases its reference count, the caller must
> decrement the reference count by calling pci_dev_put()

Thanks for the report!

This is not fully correct. I'll send a patch soon.

--
With Best Regards,
Andy Shevchenko