2022-02-28 08:15:54

by 王擎

[permalink] [raw]
Subject: [PATCH] scsi: bfa: use time_is_before_jiffies() instead of open coding it

From: Wang Qing <[email protected]>

Use the helper function time_is_{before,after}_jiffies() to improve
code readability.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/scsi/bfa/bfad_im.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/bfa/bfad_im.c b/drivers/scsi/bfa/bfad_im.c
index 759d2bb..41f49f5f
--- a/drivers/scsi/bfa/bfad_im.c
+++ b/drivers/scsi/bfa/bfad_im.c
@@ -13,6 +13,7 @@
*/

#include <linux/export.h>
+#include <linux/jiffies.h>

#include "bfad_drv.h"
#include "bfad_im.h"
@@ -870,9 +871,9 @@ bfad_ramp_up_qdepth(struct bfad_itnim_s *itnim, struct scsi_device *sdev)
{
struct scsi_device *tmp_sdev;

- if (((jiffies - itnim->last_ramp_up_time) >
+ if (time_is_before_jiffies(itnim->last_ramp_up_time +
BFA_QUEUE_FULL_RAMP_UP_TIME * HZ) &&
- ((jiffies - itnim->last_queue_full_time) >
+ time_is_before_jiffies(itnim->last_queue_full_time +
BFA_QUEUE_FULL_RAMP_UP_TIME * HZ)) {
shost_for_each_device(tmp_sdev, sdev->host) {
if (bfa_lun_queue_depth > tmp_sdev->queue_depth) {
--
2.7.4