2022-04-01 20:25:07

by 王擎

[permalink] [raw]
Subject: [PATCH] hsi: clients: remove duplicate assignment

From: Wang Qing <[email protected]>

netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
no need to repeat assignment.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/hsi/clients/ssi_protocol.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
index 21f11a5..7aacb19
--- a/drivers/hsi/clients/ssi_protocol.c
+++ b/drivers/hsi/clients/ssi_protocol.c
@@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
dev_err(&cl->device, "No memory for rx skb\n");
goto out1;
}
- skb->dev = ssi->netdev;
skb_put(skb, len * 4);
msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
if (unlikely(!msg)) {
--
2.7.4


2022-04-12 23:07:55

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] hsi: clients: remove duplicate assignment

Hi,

On Thu, Mar 31, 2022 at 05:07:38AM -0700, Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
>
> Signed-off-by: Wang Qing <[email protected]>
> ---

Thanks, queued.

-- Sebastian

> drivers/hsi/clients/ssi_protocol.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/hsi/clients/ssi_protocol.c b/drivers/hsi/clients/ssi_protocol.c
> index 21f11a5..7aacb19
> --- a/drivers/hsi/clients/ssi_protocol.c
> +++ b/drivers/hsi/clients/ssi_protocol.c
> @@ -796,7 +796,6 @@ static void ssip_rx_strans(struct hsi_client *cl, u32 cmd)
> dev_err(&cl->device, "No memory for rx skb\n");
> goto out1;
> }
> - skb->dev = ssi->netdev;
> skb_put(skb, len * 4);
> msg = ssip_alloc_data(ssi, skb, GFP_ATOMIC);
> if (unlikely(!msg)) {
> --
> 2.7.4
>

Attachments:
(No filename) (911.00 B)
 signature.asc (849.00 B)
 Download all attachments