2022-03-31 14:19:47

by 王擎

[permalink] [raw]
Subject: [PATCH] net: usb: remove duplicate assignment

From: Wang Qing <[email protected]>

netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
no need to repeat assignment.

Signed-off-by: Wang Qing <[email protected]>
---
drivers/net/usb/qmi_wwan.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/net/usb/qmi_wwan.c b/drivers/net/usb/qmi_wwan.c
index 3353e76..17cf0d1
--- a/drivers/net/usb/qmi_wwan.c
+++ b/drivers/net/usb/qmi_wwan.c
@@ -190,7 +190,6 @@ static int qmimux_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
skbn = netdev_alloc_skb(net, pkt_len + LL_MAX_HEADER);
if (!skbn)
return 0;
- skbn->dev = net;

switch (skb->data[offset + qmimux_hdr_sz] & 0xf0) {
case 0x40:
--
2.7.4


2022-03-31 16:25:22

by Bjørn Mork

[permalink] [raw]
Subject: Re: [PATCH] net: usb: remove duplicate assignment

Qing Wang <[email protected]> writes:

> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.

Thanks.

Acked-by: Bjørn Mork <[email protected]>

2022-03-31 20:35:37

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] net: usb: remove duplicate assignment

On Thu, 31 Mar 2022 05:08:14 -0700 Qing Wang wrote:
> From: Wang Qing <[email protected]>
>
> netdev_alloc_skb() has assigned ssi->netdev to skb->dev if successed,
> no need to repeat assignment.
>
> Signed-off-by: Wang Qing <[email protected]>

# Form letter - net-next is closed

We have already sent the networking pull request for 5.18
and therefore net-next is closed for new drivers, features,
code refactoring and optimizations. We are currently accepting
bug fixes only.

Please repost when net-next reopens after 5.18-rc1 is cut.

RFC patches sent for review only are obviously welcome at any time.