Add LPASS LPI pinctrl properties, which are required for Audio
functionality on herobrine based platforms of rev5+
(aka CRD 3.0/3.1) boards.
Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Co-developed-by: Venkata Prasad Potturu <[email protected]>
Signed-off-by: Venkata Prasad Potturu <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 63 +++++++++++++++++++++++
1 file changed, 63 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
index deaea3a..dc61bad 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
@@ -110,6 +110,69 @@ ap_ts_pen_1v8: &i2c13 {
* - If a pin is totally internal to Qcard then it gets Qcard name.
* - If a pin is not hooked up on Qcard, it gets no name.
*/
+&lpass_dmic01_clk {
+ drive-strength = <8>;
+ bias-disable;
+};
+
+&lpass_dmic01_data {
+ bias-pull-down;
+};
+
+&lpass_dmic01_clk_sleep {
+ drive-strength = <2>;
+};
+
+&lpass_dmic23_clk {
+ drive-strength = <8>;
+ bias-disable;
+};
+
+&lpass_dmic23_data {
+ bias-pull-down;
+};
+
+&lpass_dmic23_clk_sleep {
+ drive-strength = <2>;
+};
+
+&lpass_rx_swr_clk {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-disable;
+};
+
+&lpass_rx_swr_data {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-bus-hold;
+};
+
+&lpass_rx_swr_clk_sleep {
+ drive-strength = <2>;
+ bias-pull-down;
+};
+
+&lpass_rx_swr_data_sleep {
+ drive-strength = <2>;
+ bias-pull-down;
+};
+
+&lpass_tx_swr_clk {
+ drive-strength = <2>;
+ slew-rate = <1>;
+ bias-disable;
+};
+
+&lpass_tx_swr_data {
+ slew-rate = <1>;
+ bias-bus-hold;
+};
+
+&lpass_tx_swr_clk_sleep {
+ drive-strength = <2>;
+ bias-pull-down;
+};
&mi2s1_data0 {
drive-strength = <6>;
--
2.7.4
On Wed, May 04, 2022 at 04:46:27PM +0530, Srinivasa Rao Mandadapu wrote:
> Add LPASS LPI pinctrl properties, which are required for Audio
> functionality on herobrine based platforms of rev5+
> (aka CRD 3.0/3.1) boards.
>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> Co-developed-by: Venkata Prasad Potturu <[email protected]>
> Signed-off-by: Venkata Prasad Potturu <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 63 +++++++++++++++++++++++
> 1 file changed, 63 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> index deaea3a..dc61bad 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
> @@ -110,6 +110,69 @@ ap_ts_pen_1v8: &i2c13 {
> * - If a pin is totally internal to Qcard then it gets Qcard name.
> * - If a pin is not hooked up on Qcard, it gets no name.
> */
> +&lpass_dmic01_clk {
> + drive-strength = <8>;
> + bias-disable;
> +};
> +
> +&lpass_dmic01_data {
> + bias-pull-down;
> +};
> +
> +&lpass_dmic01_clk_sleep {
> + drive-strength = <2>;
> +};
should be after 'lpass_dmic01_clk'
> +
> +&lpass_dmic23_clk {
> + drive-strength = <8>;
> + bias-disable;
> +};
> +
> +&lpass_dmic23_data {
> + bias-pull-down;
> +};
> +
> +&lpass_dmic23_clk_sleep {
> + drive-strength = <2>;
> +};
see above
> +
> +&lpass_rx_swr_clk {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-disable;
> +};
> +
> +&lpass_rx_swr_data {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-bus-hold;
> +};
> +
> +&lpass_rx_swr_clk_sleep {
> + drive-strength = <2>;
drive strengh is the same as for 'lpass_rx_swr_clk', can be omitted?
> + bias-pull-down;
> +};
see 'lpass_dmic23_clk_sleep'
> +
> +&lpass_rx_swr_data_sleep {
> + drive-strength = <2>;
is drive strength really needed here?
> + bias-pull-down;
> +};
> +
> +&lpass_tx_swr_clk {
> + drive-strength = <2>;
> + slew-rate = <1>;
> + bias-disable;
> +};
> +
> +&lpass_tx_swr_data {
> + slew-rate = <1>;
> + bias-bus-hold;
> +};
> +
> +&lpass_tx_swr_clk_sleep {
> + drive-strength = <2>;
is drive strength really needed here?
> + bias-pull-down;
> +};
see 'lpass_dmic23_clk_sleep'
>
> &mi2s1_data0 {
> drive-strength = <6>;
> --
> 2.7.4
>
On 5/5/2022 4:01 AM, Matthias Kaehlcke wrote:
Thanks for Your time Matthias!!!
> On Wed, May 04, 2022 at 04:46:27PM +0530, Srinivasa Rao Mandadapu wrote:
>> Add LPASS LPI pinctrl properties, which are required for Audio
>> functionality on herobrine based platforms of rev5+
>> (aka CRD 3.0/3.1) boards.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> Co-developed-by: Venkata Prasad Potturu <[email protected]>
>> Signed-off-by: Venkata Prasad Potturu <[email protected]>
>> ---
>> arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 63 +++++++++++++++++++++++
>> 1 file changed, 63 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
>> index deaea3a..dc61bad 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
>> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts
>> @@ -110,6 +110,69 @@ ap_ts_pen_1v8: &i2c13 {
>> * - If a pin is totally internal to Qcard then it gets Qcard name.
>> * - If a pin is not hooked up on Qcard, it gets no name.
>> */
>> +&lpass_dmic01_clk {
>> + drive-strength = <8>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_dmic01_data {
>> + bias-pull-down;
>> +};
>> +
>> +&lpass_dmic01_clk_sleep {
>> + drive-strength = <2>;
>> +};
> should be after 'lpass_dmic01_clk'
Okay. Will sort accordingly.
>
>> +
>> +&lpass_dmic23_clk {
>> + drive-strength = <8>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_dmic23_data {
>> + bias-pull-down;
>> +};
>> +
>> +&lpass_dmic23_clk_sleep {
>> + drive-strength = <2>;
>> +};
> see above
Okay.
>
>> +
>> +&lpass_rx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_rx_swr_data {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>> +
>> +&lpass_rx_swr_clk_sleep {
>> + drive-strength = <2>;
> drive strengh is the same as for 'lpass_rx_swr_clk', can be omitted?
Okay. Will remove it.
>
>> + bias-pull-down;
>> +};
> see 'lpass_dmic23_clk_sleep'
Okay. Will sort accordingly.
>
>> +
>> +&lpass_rx_swr_data_sleep {
>> + drive-strength = <2>;
> is drive strength really needed here?
Okay. Will remove it.
>
>> + bias-pull-down;
>> +};
>> +
>> +&lpass_tx_swr_clk {
>> + drive-strength = <2>;
>> + slew-rate = <1>;
>> + bias-disable;
>> +};
>> +
>> +&lpass_tx_swr_data {
>> + slew-rate = <1>;
>> + bias-bus-hold;
>> +};
>> +
>> +&lpass_tx_swr_clk_sleep {
>> + drive-strength = <2>;
> is drive strength really needed here?
Okay. Will remove it.
>
>> + bias-pull-down;
>> +};
> see 'lpass_dmic23_clk_sleep'
Okay. Will sort accordingly.
>
>>
>> &mi2s1_data0 {
>> drive-strength = <6>;
>> --
>> 2.7.4
>>