2022-05-11 09:08:49

by baihaowen

Subject: [PATCH] md: remove useless INIT_LIST_HEAD()

list candidates has been inited staticly through LIST_HEAD,
so there's no need to call another INIT_LIST_HEAD. Simply remove
it.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/md/md.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 707e802d0082..eb2b23ef5ecc 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6491,7 +6491,6 @@ static void autorun_devices(int part)
struct md_rdev, same_set);

pr_debug("md: considering %s ...\n", bdevname(rdev0->bdev,b));
- INIT_LIST_HEAD(&candidates);
rdev_for_each_list(rdev, tmp, &pending_raid_disks)
if (super_90_load(rdev, rdev0, 0) >= 0) {
pr_debug("md: adding %s ...\n",
--
2.7.4

2022-05-11 09:30:57

by Paul Menzel

Subject: Re: [PATCH] md: remove useless INIT_LIST_HEAD()

Dear Haowen,


Thank you for your patch.

Am 11.05.22 um 04:44 schrieb Haowen Bai:
> list candidates has been inited staticly through LIST_HEAD,

initialized statically

> so there's no need to call another INIT_LIST_HEAD. Simply remove
> it.

Please reflow for 75 characters per line.

> Signed-off-by: Haowen Bai <[email protected]>
> ---
> drivers/md/md.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index 707e802d0082..eb2b23ef5ecc 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -6491,7 +6491,6 @@ static void autorun_devices(int part)
> struct md_rdev, same_set);
>
> pr_debug("md: considering %s ...\n", bdevname(rdev0->bdev,b));
> - INIT_LIST_HEAD(&candidates);
> rdev_for_each_list(rdev, tmp, &pending_raid_disks)
> if (super_90_load(rdev, rdev0, 0) >= 0) {
> pr_debug("md: adding %s ...\n",


Kind regards,

Paul

2022-05-11 11:03:45

by baihaowen

Subject: [PATCH V2] md: remove useless INIT_LIST_HEAD()

list candidates has been initialized statically through LIST_HEAD,
so there's no need to call another INIT_LIST_HEAD. Simply remove it.

Signed-off-by: Haowen Bai <[email protected]>
---
V1->V2: fix typo at description.
drivers/md/md.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 707e802d0082..eb2b23ef5ecc 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -6491,7 +6491,6 @@ static void autorun_devices(int part)
struct md_rdev, same_set);

pr_debug("md: considering %s ...\n", bdevname(rdev0->bdev,b));
- INIT_LIST_HEAD(&candidates);
rdev_for_each_list(rdev, tmp, &pending_raid_disks)
if (super_90_load(rdev, rdev0, 0) >= 0) {
pr_debug("md: adding %s ...\n",
--
2.7.4