2022-04-05 03:04:48

by CGEL

Subject: [PATCH] powerpc/sysdev: fix refcount leak in icp_opal_init()

From: Lv Ruyi <[email protected]>

The of_find_compatible_node() function returns a node pointer with
refcount incremented, use of_node_put() on it when done.

Reported-by: Zeal Robot <[email protected]>
Signed-off-by: Lv Ruyi <[email protected]>
---
arch/powerpc/sysdev/xics/icp-opal.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/sysdev/xics/icp-opal.c b/arch/powerpc/sysdev/xics/icp-opal.c
index bda4c32582d9..4dae624b9f2f 100644
--- a/arch/powerpc/sysdev/xics/icp-opal.c
+++ b/arch/powerpc/sysdev/xics/icp-opal.c
@@ -196,6 +196,7 @@ int __init icp_opal_init(void)

printk("XICS: Using OPAL ICP fallbacks\n");

+ of_node_put(np);
return 0;
}

--
2.25.1

2022-05-24 16:03:19

by Michael Ellerman

Subject: Re: [PATCH] powerpc/sysdev: fix refcount leak in icp_opal_init()

On Sat, 2 Apr 2022 01:34:19 +0000, [email protected] wrote:
> From: Lv Ruyi <[email protected]>
>
> The of_find_compatible_node() function returns a node pointer with
> refcount incremented, use of_node_put() on it when done.
>
>

Applied to powerpc/next.

[1/1] powerpc/sysdev: fix refcount leak in icp_opal_init()
https://git.kernel.org/powerpc/c/5dd9e27ea4a39f7edd4bf81e9e70208e7ac0b7c9

cheers