2022-06-10 15:07:53

by Srinivasa Rao Mandadapu

Subject: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms

Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280
platforms. Which is required to make clock voting as optional for ADSP
bypass platforms.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
---
.../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
index d32ee32..ea9920c 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
@@ -17,7 +17,14 @@ description: |

properties:
compatible:
- const: qcom,sc7280-lpass-lpi-pinctrl
+ enum:
+ - qcom,sc7280-lpass-lpi-pinctrl
+
+ qcom,adsp-bypass-mode:
+ description:
+ Tells pin controllers want to make clocks optional for ADSP bypass
+ targets.
+ type: boolean

reg:
minItems: 2
--
2.7.4

2022-06-10 20:39:02

by Stephen Boyd

Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms

Quoting Srinivasa Rao Mandadapu (2022-06-10 07:45:34)
> Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280
> platforms. Which is required to make clock voting as optional for ADSP
> bypass platforms.
>
> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
> ---
> .../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> index d32ee32..ea9920c 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
> @@ -17,7 +17,14 @@ description: |
>
> properties:
> compatible:
> - const: qcom,sc7280-lpass-lpi-pinctrl
> + enum:
> + - qcom,sc7280-lpass-lpi-pinctrl

Drop this part.

> +
> + qcom,adsp-bypass-mode:
> + description:
> + Tells pin controllers want to make clocks optional for ADSP bypass
> + targets.

How about "ADSP is in bypass mode"?

2022-06-11 08:30:12

by Srinivasa Rao Mandadapu

Subject: Re: [PATCH v3 1/2] dt-bindings: pinctrl: qcom: sc7280: Add boolean param for ADSP bypass platforms

On 6/11/2022 1:34 AM, Stephen Boyd wrote:
Thanks for Your time Stephen!!!
> Quoting Srinivasa Rao Mandadapu (2022-06-10 07:45:34)
>> Add boolean param qcom,adsp-bypass-mode to support adsp bypassed sc7280
>> platforms. Which is required to make clock voting as optional for ADSP
>> bypass platforms.
>>
>> Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
>> ---
>> .../bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml | 9 ++++++++-
>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> index d32ee32..ea9920c 100644
>> --- a/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,sc7280-lpass-lpi-pinctrl.yaml
>> @@ -17,7 +17,14 @@ description: |
>>
>> properties:
>> compatible:
>> - const: qcom,sc7280-lpass-lpi-pinctrl
>> + enum:
>> + - qcom,sc7280-lpass-lpi-pinctrl
> Drop this part.
Okay. Will revert this change.
>
>> +
>> + qcom,adsp-bypass-mode:
>> + description:
>> + Tells pin controllers want to make clocks optional for ADSP bypass
>> + targets.
> How about "ADSP is in bypass mode"?

You mean, description like below?

qcom,adsp-bypass-mode:
description:
ADSP is in bypass mode.