Ever since {suspend,resume}_device_irqs() were introduced in 2009
by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
resuming device interrupts"), they've been exported even though there
are no module users and never will be: The functions are solely called
by the PM core, which is always built-in. Unexport them.
Signed-off-by: Lukas Wunner <[email protected]>
---
kernel/irq/pm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index ca71123a6130..c556bc49d213 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -147,7 +147,6 @@ void suspend_device_irqs(void)
synchronize_irq(irq);
}
}
-EXPORT_SYMBOL_GPL(suspend_device_irqs);
static void resume_irq(struct irq_desc *desc)
{
@@ -259,4 +258,3 @@ void resume_device_irqs(void)
{
resume_irqs(false);
}
-EXPORT_SYMBOL_GPL(resume_device_irqs);
--
2.35.2
On Fri, Jun 10, 2022 at 9:41 AM Lukas Wunner <[email protected]> wrote:
>
> Ever since {suspend,resume}_device_irqs() were introduced in 2009
> by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
> resuming device interrupts"), they've been exported even though there
> are no module users and never will be: The functions are solely called
> by the PM core, which is always built-in. Unexport them.
>
> Signed-off-by: Lukas Wunner <[email protected]>
Reviewed-by: Rafael J. Wysocki <[email protected]>
or I can take it if no one else does.
> ---
> kernel/irq/pm.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
> index ca71123a6130..c556bc49d213 100644
> --- a/kernel/irq/pm.c
> +++ b/kernel/irq/pm.c
> @@ -147,7 +147,6 @@ void suspend_device_irqs(void)
> synchronize_irq(irq);
> }
> }
> -EXPORT_SYMBOL_GPL(suspend_device_irqs);
>
> static void resume_irq(struct irq_desc *desc)
> {
> @@ -259,4 +258,3 @@ void resume_device_irqs(void)
> {
> resume_irqs(false);
> }
> -EXPORT_SYMBOL_GPL(resume_device_irqs);
> --
> 2.35.2
>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: ac165aab469895de059a4a191a2e04ddb5421d0e
Gitweb: https://git.kernel.org/tip/ac165aab469895de059a4a191a2e04ddb5421d0e
Author: Lukas Wunner <[email protected]>
AuthorDate: Fri, 10 Jun 2022 09:40:50 +02:00
Committer: Thomas Gleixner <[email protected]>
CommitterDate: Mon, 13 Jun 2022 12:27:37 +02:00
genirq/PM: Unexport {suspend,resume}_device_irqs()
Ever since {suspend,resume}_device_irqs() were introduced in 2009
by commit 0a0c5168df27 ("PM: Introduce functions for suspending and
resuming device interrupts"), they've been exported even though there
are no module users and never will be: The functions are solely called
by the PM core, which is always built-in. Unexport them.
Signed-off-by: Lukas Wunner <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Reviewed-by: Rafael J. Wysocki <[email protected]>
Link: https://lore.kernel.org/r/fad9b50609f9d9828ea14772dbd4d195713f1c4b.1654846687.git.lukas@wunner.de
---
kernel/irq/pm.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/irq/pm.c b/kernel/irq/pm.c
index ca71123..c556bc4 100644
--- a/kernel/irq/pm.c
+++ b/kernel/irq/pm.c
@@ -147,7 +147,6 @@ void suspend_device_irqs(void)
synchronize_irq(irq);
}
}
-EXPORT_SYMBOL_GPL(suspend_device_irqs);
static void resume_irq(struct irq_desc *desc)
{
@@ -259,4 +258,3 @@ void resume_device_irqs(void)
{
resume_irqs(false);
}
-EXPORT_SYMBOL_GPL(resume_device_irqs);