2022-05-06 13:41:23

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH v14 0/4] Add lpass pin control support for audio on sc7280 based targets

This patch set is to add lpass pin control support for Audio over I2S,
wcd codec and digital mics.

Changes Since V13:
-- Remove redundant properties in lpass lpi pin control nodes.
-- Sort lpass lpi pin control nodes.
Changes Since V12:
-- Split common lpass lpi pin control nodes to functionality specific nodes.
-- Move common pin control properties to corresponding default nodes.
Changes Since V11:
-- Move CRD specific pinmux nodes to crd specific file.
Changes Since V10:
-- Add lpass lpi pinmux and MI2S pinmux support for rev5+ boards.
-- Remove dependency patches link in the cover-letter as it is merged.
Changes Since V9:
-- Remove redundant prefix in node name.
Changes Since V8:
-- Modify label and node names to lpass specific.
-- Sort nodes as per node names and kind of nodes like pinctrl and device nodes.
Changes Since V7:
-- Sort mi2s pincontrol nodes as per node name.
-- Fix typo errors.
Changes Since V6:
-- Move amp_en node to corresponding consumer patch.
-- Update label and node names.
-- Remove redundant drive-strengths.
-- Remove herobrine crd specific mi2s configuration.
Changes Since V5:
-- Remove redundant function property in amp_en node.
-- Move board specific properties of lpass pin control node to board specific file.
-- Remove redundant properties in pin control nodes.
-- Move wcd938x codec reset and CTIA/OMTP pin control patches to other series.
Changes Since V4:
-- Add primary and secondary I2S pinmux nodes for herobrine specific targets.
Changes Since V3:
-- Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset selection.
Changes Since V2:
-- Move lpass pin control node to main dtsi file.
-- Sort nodes alphabetically.
-- Remove redundant wcd reset gpio nodes.
-- Remove redundant input-enable field in dmic pin control nodes.
-- Update amp_en node.
-- Fix typo errors.
-- Modify node names.
-- Create patches on latest kernel.
Changes Since V1:
-- Merge pinmux and pinconf properties in amp_en and wcd pin reset node.
-- Split common i2s pin control nodes to functionality specific nodes.
-- Move board specific properties to board specific dtsi file.
-- Update dmic pin control node name.

Srinivasa Rao Mandadapu (4):
arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset
arm64: dts: qcom: sc7280: Add secondary MI2S pinmux specifications for
CRD 3.0/3.1
arm64: dts: qcom: sc7280: add lpass lpi pin controller node
arm64: dts: qcom: sc7280-herobrine: Add lpi pinmux properties for CRD
3.0/3.1

arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts | 75 +++++++++++++
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 76 +++++++++++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 131 ++++++++++++++++++++++
3 files changed, 282 insertions(+)

--
2.7.4



2022-05-09 09:19:06

by Srinivasa Rao Mandadapu

[permalink] [raw]
Subject: [PATCH v14 1/4] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset

Add pinmux nodes for primary and secondary I2S for SC7280 based platforms.

Signed-off-by: Srinivasa Rao Mandadapu <[email protected]>
Co-developed-by: Venkata Prasad Potturu <[email protected]>
Signed-off-by: Venkata Prasad Potturu <[email protected]>
Reviewed-by: Matthias Kaehlcke <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 14 +++++++++++
arch/arm64/boot/dts/qcom/sc7280.dtsi | 40 ++++++++++++++++++++++++++++++++
2 files changed, 54 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 6a14259..754da58 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -367,6 +367,20 @@
bias-disable;
};

+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+};
+
&pm7325_gpios {
key_vol_up_default: key-vol-up-default {
pins = "gpio6";
diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index ccf5e95..c5b6b46 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -3890,6 +3890,46 @@
function = "edp_hot";
};

+ mi2s0_data0: mi2s0-data0 {
+ pins = "gpio98";
+ function = "mi2s0_data0";
+ };
+
+ mi2s0_data1: mi2s0-data1 {
+ pins = "gpio99";
+ function = "mi2s0_data1";
+ };
+
+ mi2s0_mclk: mi2s0-mclk {
+ pins = "gpio96";
+ function = "pri_mi2s";
+ };
+
+ mi2s0_sclk: mi2s0-sclk {
+ pins = "gpio97";
+ function = "mi2s0_sck";
+ };
+
+ mi2s0_ws: mi2s0-ws {
+ pins = "gpio100";
+ function = "mi2s0_ws";
+ };
+
+ mi2s1_data0: mi2s1-data0 {
+ pins = "gpio107";
+ function = "mi2s1_data0";
+ };
+
+ mi2s1_sclk: mi2s1-sclk {
+ pins = "gpio106";
+ function = "mi2s1_sck";
+ };
+
+ mi2s1_ws: mi2s1-ws {
+ pins = "gpio108";
+ function = "mi2s1_ws";
+ };
+
pcie1_clkreq_n: pcie1-clkreq-n {
pins = "gpio79";
function = "pcie1_clkreqn";
--
2.7.4


2022-06-27 20:27:54

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v14 0/4] Add lpass pin control support for audio on sc7280 based targets

On Thu, 5 May 2022 20:33:20 +0530, Srinivasa Rao Mandadapu wrote:
> This patch set is to add lpass pin control support for Audio over I2S,
> wcd codec and digital mics.
>
> Changes Since V13:
> -- Remove redundant properties in lpass lpi pin control nodes.
> -- Sort lpass lpi pin control nodes.
> Changes Since V12:
> -- Split common lpass lpi pin control nodes to functionality specific nodes.
> -- Move common pin control properties to corresponding default nodes.
> Changes Since V11:
> -- Move CRD specific pinmux nodes to crd specific file.
> Changes Since V10:
> -- Add lpass lpi pinmux and MI2S pinmux support for rev5+ boards.
> -- Remove dependency patches link in the cover-letter as it is merged.
> Changes Since V9:
> -- Remove redundant prefix in node name.
> Changes Since V8:
> -- Modify label and node names to lpass specific.
> -- Sort nodes as per node names and kind of nodes like pinctrl and device nodes.
> Changes Since V7:
> -- Sort mi2s pincontrol nodes as per node name.
> -- Fix typo errors.
> Changes Since V6:
> -- Move amp_en node to corresponding consumer patch.
> -- Update label and node names.
> -- Remove redundant drive-strengths.
> -- Remove herobrine crd specific mi2s configuration.
> Changes Since V5:
> -- Remove redundant function property in amp_en node.
> -- Move board specific properties of lpass pin control node to board specific file.
> -- Remove redundant properties in pin control nodes.
> -- Move wcd938x codec reset and CTIA/OMTP pin control patches to other series.
> Changes Since V4:
> -- Add primary and secondary I2S pinmux nodes for herobrine specific targets.
> Changes Since V3:
> -- Add pinctrl nodes for wcd codec reset and CTIA/OMTP headset selection.
> Changes Since V2:
> -- Move lpass pin control node to main dtsi file.
> -- Sort nodes alphabetically.
> -- Remove redundant wcd reset gpio nodes.
> -- Remove redundant input-enable field in dmic pin control nodes.
> -- Update amp_en node.
> -- Fix typo errors.
> -- Modify node names.
> -- Create patches on latest kernel.
> Changes Since V1:
> -- Merge pinmux and pinconf properties in amp_en and wcd pin reset node.
> -- Split common i2s pin control nodes to functionality specific nodes.
> -- Move board specific properties to board specific dtsi file.
> -- Update dmic pin control node name.
>
> [...]

Applied, thanks!

[1/4] arm64: dts: qcom: sc7280: Add pinmux for I2S speaker and Headset
commit: b9e3f65ecf85854c9717467c3cffaca194edd19f
[2/4] arm64: dts: qcom: sc7280: Add secondary MI2S pinmux specifications for CRD 3.0/3.1
commit: 06c73a39c38b9321e638002450dcb22aa592ae99
[3/4] arm64: dts: qcom: sc7280: add lpass lpi pin controller node
commit: 32d4541abe0f981cbcc45e142543d5811fd07692
[4/4] arm64: dts: qcom: sc7280-herobrine: Add lpi pinmux properties for CRD 3.0/3.1
commit: a4c1fc8cff056461b9bd0e07e775f93073b4d527

Best regards,
--
Bjorn Andersson <[email protected]>