From: ChiYuan Huang <[email protected]>
From the common binding, 'enable-gpio' or 'enable-gpios' are all well
for external 'enable' gpio.
'gpiod_get_from_of_node' only parse the 'enable' property, it need to
add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index.
Although fwnode parsing is not preferred, but 'of_parse_cb' already can
guarantee the callback will only be used by regulator of_node parsing.
Signed-off-by: ChiYuan Huang <[email protected]>
---
drivers/regulator/mt6370-regulator.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/regulator/mt6370-regulator.c b/drivers/regulator/mt6370-regulator.c
index bc356b4..949b2c7 100644
--- a/drivers/regulator/mt6370-regulator.c
+++ b/drivers/regulator/mt6370-regulator.c
@@ -153,7 +153,8 @@ static int mt6370_of_parse_cb(struct device_node *np,
struct gpio_desc *enable_gpio;
int ret;
- enable_gpio = gpiod_get_from_of_node(np, "enable", 0, GPIOD_OUT_HIGH |
+ enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
+ GPIOD_OUT_HIGH |
GPIOD_FLAGS_BIT_NONEXCLUSIVE,
desc->name);
if (IS_ERR(enable_gpio)) {
--
2.7.4
Il 29/06/22 03:41, cy_huang ha scritto:
> From: ChiYuan Huang <[email protected]>
>
> From the common binding, 'enable-gpio' or 'enable-gpios' are all well
> for external 'enable' gpio.
>
> 'gpiod_get_from_of_node' only parse the 'enable' property, it need to
> add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index.
> Although fwnode parsing is not preferred, but 'of_parse_cb' already can
> guarantee the callback will only be used by regulator of_node parsing.
>
> Signed-off-by: ChiYuan Huang <[email protected]>
> ---
> drivers/regulator/mt6370-regulator.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/mt6370-regulator.c b/drivers/regulator/mt6370-regulator.c
> index bc356b4..949b2c7 100644
> --- a/drivers/regulator/mt6370-regulator.c
> +++ b/drivers/regulator/mt6370-regulator.c
> @@ -153,7 +153,8 @@ static int mt6370_of_parse_cb(struct device_node *np,
> struct gpio_desc *enable_gpio;
> int ret;
>
> - enable_gpio = gpiod_get_from_of_node(np, "enable", 0, GPIOD_OUT_HIGH |
> + enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
Since this driver is never calling gpiod_put(), you can even fix that in one shot.
Just use devm_fwnode_gpiod_get() here, as it's guaranteed that priv->dev is
initialized at this time.
Cheers,
Angelo
AngeloGioacchino Del Regno <[email protected]> 於
2022年6月29日 週三 下午4:23寫道：
>
> Il 29/06/22 03:41, cy_huang ha scritto:
> > From: ChiYuan Huang <[email protected]>
> >
> > From the common binding, 'enable-gpio' or 'enable-gpios' are all well
> > for external 'enable' gpio.
> >
> > 'gpiod_get_from_of_node' only parse the 'enable' property, it need to
> > add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index.
> > Although fwnode parsing is not preferred, but 'of_parse_cb' already can
> > guarantee the callback will only be used by regulator of_node parsing.
> >
> > Signed-off-by: ChiYuan Huang <[email protected]>
> > ---
> > drivers/regulator/mt6370-regulator.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/regulator/mt6370-regulator.c b/drivers/regulator/mt6370-regulator.c
> > index bc356b4..949b2c7 100644
> > --- a/drivers/regulator/mt6370-regulator.c
> > +++ b/drivers/regulator/mt6370-regulator.c
> > @@ -153,7 +153,8 @@ static int mt6370_of_parse_cb(struct device_node *np,
> > struct gpio_desc *enable_gpio;
> > int ret;
> >
> > - enable_gpio = gpiod_get_from_of_node(np, "enable", 0, GPIOD_OUT_HIGH |
> > + enable_gpio = fwnode_gpiod_get_index(of_fwnode_handle(np), "enable", 0,
>
> Since this driver is never calling gpiod_put(), you can even fix that in one shot.
>
> Just use devm_fwnode_gpiod_get() here, as it's guaranteed that priv->dev is
> initialized at this time.
>
Refer to the regulator framework,it will take over the gpio_desc.
You cannot use devm version for 'gpiod_get'.
> Cheers,
> Angelo
>
>
On Wed, 29 Jun 2022 09:41:00 +0800, cy_huang wrote:
> From: ChiYuan Huang <[email protected]>
>
> From the common binding, 'enable-gpio' or 'enable-gpios' are all well
> for external 'enable' gpio.
>
> 'gpiod_get_from_of_node' only parse the 'enable' property, it need to
> add the gpio suffix. It's more convenient to use fwnode_gpiod_get_index.
> Although fwnode parsing is not preferred, but 'of_parse_cb' already can
> guarantee the callback will only be used by regulator of_node parsing.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next
Thanks!
[1/2] regulator: mt6370: Use 'fwnode_gpiod_get_index' to fix gpio parsing
commit: 4806c991bf4ff959acf921ea72f931a945a968ae
[2/2] regulator: mt6370: Use the correct header for platform_device_id
commit: 46ae6fb58fd49c4cb2d1ca34e87d603b7c96ba97
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark