2022-05-19 16:48:25

by Krzysztof Kozlowski

Subject: [PATCH v2] remoteproc: qcom: correct kerneldoc

Correct kerneldoc warnings like:

drivers/remoteproc/qcom_common.c:68:
warning: expecting prototype for struct minidump_subsystem_toc. Prototype was for struct minidump_subsystem instead

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Stephen Boyd <[email protected]>

---

Changes since v1:
1. Split series per subsystem.
2. Add tag.
---
drivers/remoteproc/qcom_common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/remoteproc/qcom_common.c b/drivers/remoteproc/qcom_common.c
index 4b91e3c9eafa..020349f8979d 100644
--- a/drivers/remoteproc/qcom_common.c
+++ b/drivers/remoteproc/qcom_common.c
@@ -50,7 +50,7 @@ struct minidump_region {
};

/**
- * struct minidump_subsystem_toc: Subsystem's SMEM Table of content
+ * struct minidump_subsystem - Subsystem's SMEM Table of content
* @status : Subsystem toc init status
* @enabled : if set to 1, this region would be copied during coredump
* @encryption_status: Encryption status for this subsystem
@@ -68,7 +68,7 @@ struct minidump_subsystem {
};

/**
- * struct minidump_global_toc: Global Table of Content
+ * struct minidump_global_toc - Global Table of Content
* @status : Global Minidump init status
* @md_revision : Minidump revision
* @enabled : Minidump enable status
--
2.32.0

2022-06-20 19:24:44

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] remoteproc: qcom: correct kerneldoc

On 19/05/2022 09:33, Krzysztof Kozlowski wrote:
> Correct kerneldoc warnings like:
>
> drivers/remoteproc/qcom_common.c:68:
> warning: expecting prototype for struct minidump_subsystem_toc. Prototype was for struct minidump_subsystem instead
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Stephen Boyd <[email protected]>
>

Although these warnings are not that important, they are still warnings
we want to fix to be able to compile with W=1.

Is there anyone willing to pick it up? Any other comments?


Best regards,
Krzysztof

2022-07-18 23:16:59

by Bjorn Andersson

Subject: Re: (subset) [PATCH v2] remoteproc: qcom: correct kerneldoc

On Thu, 19 May 2022 09:33:49 +0200, Krzysztof Kozlowski wrote:
> Correct kerneldoc warnings like:
>
> drivers/remoteproc/qcom_common.c:68:
> warning: expecting prototype for struct minidump_subsystem_toc. Prototype was for struct minidump_subsystem instead
>
>

Applied, thanks!

[1/1] remoteproc: qcom: correct kerneldoc
commit: d5f8c4c66a368e21a105c42042803526cd3ccc15

Best regards,
--
Bjorn Andersson <[email protected]>