2014-02-26 15:46:45

by Rashika Kheria

Subject: [PATCH] drivers: cpufreq: Remove unused function in cpufreq.c

Remove unused function show_boost() in drivers/cpufreq/cpufreq.c.

This eliminates the following warning in drivers/cpufreq/cpufreq.c:
drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <[email protected]>
---
drivers/cpufreq/cpufreq.c | 6 ------
1 file changed, 6 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 08ca8c9..6dce474 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -352,12 +352,6 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
/*********************************************************************
* SYSFS INTERFACE *
*********************************************************************/
-ssize_t show_boost(struct kobject *kobj,
- struct attribute *attr, char *buf)
-{
- return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
-}
-
static ssize_t store_boost(struct kobject *kobj, struct attribute *attr,
const char *buf, size_t count)
{
--
1.7.9.5

2014-02-26 16:13:37

by Josh Triplett

Subject: Re: [PATCH] drivers: cpufreq: Remove unused function in cpufreq.c

On Wed, Feb 26, 2014 at 09:16:25PM +0530, Rashika Kheria wrote:
> Remove unused function show_boost() in drivers/cpufreq/cpufreq.c.
>
> This eliminates the following warning in drivers/cpufreq/cpufreq.c:
> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>

Reviewed-by: Josh Triplett <[email protected]>

> drivers/cpufreq/cpufreq.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 08ca8c9..6dce474 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -352,12 +352,6 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> /*********************************************************************
> * SYSFS INTERFACE *
> *********************************************************************/
> -ssize_t show_boost(struct kobject *kobj,
> - struct attribute *attr, char *buf)
> -{
> - return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> -}
> -
> static ssize_t store_boost(struct kobject *kobj, struct attribute *attr,
> const char *buf, size_t count)
> {
> --
> 1.7.9.5
>

2014-02-26 16:43:31

by Rashika Kheria

Subject: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c

Mark function as static in cpufreq.c because it is not
used outside this file.

This eliminates the following warning in cpufreq.c:
drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <[email protected]>
---
Changes since v1:
Incorrect Fix
Changes since v2:
Show Changelog

drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 08ca8c9..54fd670 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
/*********************************************************************
* SYSFS INTERFACE *
*********************************************************************/
-ssize_t show_boost(struct kobject *kobj,
+static ssize_t show_boost(struct kobject *kobj,
struct attribute *attr, char *buf)
{
return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
--
1.7.9.5

2014-02-26 21:41:47

by Rafael J. Wysocki

Subject: Re: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c

On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote:
> Mark function as static in cpufreq.c because it is not
> used outside this file.
>
> This eliminates the following warning in cpufreq.c:
> drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
>
> Signed-off-by: Rashika Kheria <[email protected]>

v2 has been Reviewed-by: Josh already, right?

> ---
> Changes since v1:
> Incorrect Fix
> Changes since v2:
> Show Changelog
>
> drivers/cpufreq/cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 08ca8c9..54fd670 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> /*********************************************************************
> * SYSFS INTERFACE *
> *********************************************************************/
> -ssize_t show_boost(struct kobject *kobj,
> +static ssize_t show_boost(struct kobject *kobj,
> struct attribute *attr, char *buf)
> {
> return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
>

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

2014-02-26 22:16:59

by Josh Triplett

Subject: Re: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c

On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote:
> On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote:
> > Mark function as static in cpufreq.c because it is not
> > used outside this file.
> >
> > This eliminates the following warning in cpufreq.c:
> > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
> >
> > Signed-off-by: Rashika Kheria <[email protected]>
>
> v2 has been Reviewed-by: Josh already, right?

Feel free to forward-propagate to v3 as well, if that helps.

> > ---
> > Changes since v1:
> > Incorrect Fix
> > Changes since v2:
> > Show Changelog
> >
> > drivers/cpufreq/cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 08ca8c9..54fd670 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> > /*********************************************************************
> > * SYSFS INTERFACE *
> > *********************************************************************/
> > -ssize_t show_boost(struct kobject *kobj,
> > +static ssize_t show_boost(struct kobject *kobj,
> > struct attribute *attr, char *buf)
> > {
> > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.

2014-02-26 23:52:29

by Rafael J. Wysocki

Subject: Re: [PATCH v3] drivers: cpufreq: Mark function as static in cpufreq.c

On Wednesday, February 26, 2014 02:16:51 PM [email protected] wrote:
> On Wed, Feb 26, 2014 at 10:56:45PM +0100, Rafael J. Wysocki wrote:
> > On Wednesday, February 26, 2014 10:12:42 PM Rashika Kheria wrote:
> > > Mark function as static in cpufreq.c because it is not
> > > used outside this file.
> > >
> > > This eliminates the following warning in cpufreq.c:
> > > drivers/cpufreq/cpufreq.c:355:9: warning: no previous prototype for ‘show_boost’ [-Wmissing-prototypes]
> > >
> > > Signed-off-by: Rashika Kheria <[email protected]>
> >
> > v2 has been Reviewed-by: Josh already, right?
>
> Feel free to forward-propagate to v3 as well, if that helps.

OK

Applied, thanks!

> > > ---
> > > Changes since v1:
> > > Incorrect Fix
> > > Changes since v2:
> > > Show Changelog
> > >
> > > drivers/cpufreq/cpufreq.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > > index 08ca8c9..54fd670 100644
> > > --- a/drivers/cpufreq/cpufreq.c
> > > +++ b/drivers/cpufreq/cpufreq.c
> > > @@ -352,7 +352,7 @@ EXPORT_SYMBOL_GPL(cpufreq_notify_post_transition);
> > > /*********************************************************************
> > > * SYSFS INTERFACE *
> > > *********************************************************************/
> > > -ssize_t show_boost(struct kobject *kobj,
> > > +static ssize_t show_boost(struct kobject *kobj,
> > > struct attribute *attr, char *buf)
> > > {
> > > return sprintf(buf, "%d\n", cpufreq_driver->boost_enabled);
> > >
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html

--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.