2022-06-03 19:08:42

by Miaoqian Lin

Subject: [PATCH] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader

of_find_node_by_path() returns remote device nodepointer with
refcount incremented, we should use of_node_put() on it when done.
Add missing of_node_put() to avoid refcount leak.

Fixes: 0afacde3df4c ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader")
Signed-off-by: Miaoqian Lin <[email protected]>
---
arch/powerpc/platforms/cell/spufs/inode.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/powerpc/platforms/cell/spufs/inode.c b/arch/powerpc/platforms/cell/spufs/inode.c
index 34334c32b7f5..320008528edd 100644
--- a/arch/powerpc/platforms/cell/spufs/inode.c
+++ b/arch/powerpc/platforms/cell/spufs/inode.c
@@ -660,6 +660,7 @@ spufs_init_isolated_loader(void)
return;

loader = of_get_property(dn, "loader", &size);
+ of_node_put(dn);
if (!loader)
return;

--
2.25.1

2022-06-04 02:14:32

by Arnd Bergmann

Subject: Re: [PATCH] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader

On Fri, Jun 3, 2022 at 2:15 PM Miaoqian Lin <[email protected]> wrote:
>
> of_find_node_by_path() returns remote device nodepointer with
> refcount incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 0afacde3df4c ("[POWERPC] spufs: allow isolated mode apps by starting the SPE loader")
> Signed-off-by: Miaoqian Lin <[email protected]>


Acked-by: Arnd Bergmann <[email protected]>

2022-08-02 11:04:50

by Michael Ellerman

Subject: Re: [PATCH] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader

On Fri, 3 Jun 2022 16:15:42 +0400, Miaoqian Lin wrote:
> of_find_node_by_path() returns remote device nodepointer with
> refcount incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
>

Applied to powerpc/next.

[1/1] powerpc/spufs: Fix refcount leak in spufs_init_isolated_loader
https://git.kernel.org/powerpc/c/6ac059dacffa8ab2f7798f20e4bd3333890c541c

cheers