The USB 2.0 port of sc7280 is currently not used by any herobrine
board. Delete the device tree entries that enable it.
Signed-off-by: Matthias Kaehlcke <[email protected]>
---
I was also told that the 2.0 port is for the Embedded USB Debugger
(EUD) only, but I'm not sure if that's true. From the Linux side
it looks like a regular dwc3 controller.
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 3f8996c00b05..b2f0404d3f71 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -606,18 +606,6 @@ &usb_1_qmpphy {
status = "okay";
};
-&usb_2 {
- status = "okay";
-};
-
-&usb_2_dwc3 {
- dr_mode = "host";
-};
-
-&usb_2_hsphy {
- status = "okay";
-};
-
/* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
&dp_hot_plug_det {
--
2.37.2.672.g94769d06f0-goog
Hi,
On Fri, Aug 26, 2022 at 8:48 AM Matthias Kaehlcke <[email protected]> wrote:
>
> The USB 2.0 port of sc7280 is currently not used by any herobrine
> board. Delete the device tree entries that enable it.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---
> I was also told that the 2.0 port is for the Embedded USB Debugger
> (EUD) only, but I'm not sure if that's true. From the Linux side
> it looks like a regular dwc3 controller.
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 12 ------------
> 1 file changed, 12 deletions(-)
I can confirm it's not hooked up anywhere on herobrine-class boards.
Disabling looks good to me. If we later have a herobrine variant where
this is enabled we can enable it just for that variant.
Reviewed-by: Douglas Anderson <[email protected]>
On 26.08.2022 17:48, Matthias Kaehlcke wrote:
> The USB 2.0 port of sc7280 is currently not used by any herobrine
> board. Delete the device tree entries that enable it.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
> I was also told that the 2.0 port is for the Embedded USB Debugger
> (EUD) only, but I'm not sure if that's true. From the Linux side
> it looks like a regular dwc3 controller.
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 12 ------------
> 1 file changed, 12 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index 3f8996c00b05..b2f0404d3f71 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -606,18 +606,6 @@ &usb_1_qmpphy {
> status = "okay";
> };
>
> -&usb_2 {
> - status = "okay";
> -};
> -
> -&usb_2_dwc3 {
> - dr_mode = "host";
> -};
> -
> -&usb_2_hsphy {
> - status = "okay";
> -};
> -
> /* PINCTRL - ADDITIONS TO NODES IN PARENT DEVICE TREE FILES */
>
> &dp_hot_plug_det {
On Fri, 26 Aug 2022 08:48:27 -0700, Matthias Kaehlcke wrote:
> The USB 2.0 port of sc7280 is currently not used by any herobrine
> board. Delete the device tree entries that enable it.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sc7280-herobrine: Don't enable the USB 2.0 port
commit: 643d05163e3a18f224e4e1a80de09b2b74e1d249
Best regards,
--
Bjorn Andersson <[email protected]>