2017-08-13 09:40:22

by Arvind Yadav

Subject: [PATCH] CPUFREQ: Loongson2: constify platform_device_id

platform_device_id are not supposed to change at runtime. All functions
working with platform_device_id provided by <linux/platform_device.h>
work with const platform_device_id. So mark the non-const structs as
const.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/cpufreq/loongson2_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
index 9ac27b2..da34469 100644
--- a/drivers/cpufreq/loongson2_cpufreq.c
+++ b/drivers/cpufreq/loongson2_cpufreq.c
@@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
.attr = cpufreq_generic_attr,
};

-static struct platform_device_id platform_device_ids[] = {
+static const struct platform_device_id platform_device_ids[] = {
{
.name = "loongson2_cpufreq",
},
--
2.7.4

2017-08-16 03:26:03

by Viresh Kumar

Subject: Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id

On 13-08-17, 15:10, Arvind Yadav wrote:
> platform_device_id are not supposed to change at runtime. All functions
> working with platform_device_id provided by <linux/platform_device.h>
> work with const platform_device_id. So mark the non-const structs as
> const.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> index 9ac27b2..da34469 100644
> --- a/drivers/cpufreq/loongson2_cpufreq.c
> +++ b/drivers/cpufreq/loongson2_cpufreq.c
> @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
> .attr = cpufreq_generic_attr,
> };
>
> -static struct platform_device_id platform_device_ids[] = {
> +static const struct platform_device_id platform_device_ids[] = {
> {
> .name = "loongson2_cpufreq",
> },

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2017-08-22 13:39:07

by Rafael J. Wysocki

Subject: Re: [PATCH] CPUFREQ: Loongson2: constify platform_device_id

On Wednesday, August 16, 2017 5:25:59 AM CEST Viresh Kumar wrote:
> On 13-08-17, 15:10, Arvind Yadav wrote:
> > platform_device_id are not supposed to change at runtime. All functions
> > working with platform_device_id provided by <linux/platform_device.h>
> > work with const platform_device_id. So mark the non-const structs as
> > const.
> >
> > Signed-off-by: Arvind Yadav <[email protected]>
> > ---
> > drivers/cpufreq/loongson2_cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/loongson2_cpufreq.c b/drivers/cpufreq/loongson2_cpufreq.c
> > index 9ac27b2..da34469 100644
> > --- a/drivers/cpufreq/loongson2_cpufreq.c
> > +++ b/drivers/cpufreq/loongson2_cpufreq.c
> > @@ -114,7 +114,7 @@ static struct cpufreq_driver loongson2_cpufreq_driver = {
> > .attr = cpufreq_generic_attr,
> > };
> >
> > -static struct platform_device_id platform_device_ids[] = {
> > +static const struct platform_device_id platform_device_ids[] = {
> > {
> > .name = "loongson2_cpufreq",
> > },
>
> Acked-by: Viresh Kumar <[email protected]>
>
>

Applied, thanks!