2022-10-18 23:22:14

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 0/5] dma/arm64: qcom: use one compatible also for 0x10000 offset

Hi,

Changes since v1
================
1. Rebase on v6 of Richard's patch.
2. Add tags.

Dependencies
============
1. DT bindings and DMA driver change depends contextually on:
https://lore.kernel.org/all/[email protected]/

2. DTS patches are independent, although they will spark some dtbs_check
warnings (due to change in bindings).

Best regards,
Krzysztof

Krzysztof Kozlowski (5):
dt-bindings: dma: qcom: gpi: Use sm6350 fallback
dmaengine: qcom: gpi: Document preferred SM6350 binding
arm64: dts: qcom: sc7280: Add GPI DMA compatible fallback
arm64: dts: qcom: sm8350: Add GPI DMA compatible fallback
arm64: dts: qcom: sm8450: Add GPI DMA compatible fallback

Documentation/devicetree/bindings/dma/qcom,gpi.yaml | 9 ++++++---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
arch/arm64/boot/dts/qcom/sm8350.dtsi | 6 +++---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++---
drivers/dma/qcom/gpi.c | 7 ++++---
5 files changed, 18 insertions(+), 14 deletions(-)

--
2.34.1


2022-10-18 23:25:24

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 3/5] arm64: dts: qcom: sc7280: Add GPI DMA compatible fallback

Use SM6350 as fallback for GPI DMA, to indicate devices are compatible
and that drivers can bind with only one compatible.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 212580316d3e..2a167412fa6a 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -920,7 +920,7 @@ opp-384000000 {

gpi_dma0: dma-controller@900000 {
#dma-cells = <3>;
- compatible = "qcom,sc7280-gpi-dma";
+ compatible = "qcom,sc7280-gpi-dma", "qcom,sm6350-gpi-dma";
reg = <0 0x00900000 0 0x60000>;
interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 245 IRQ_TYPE_LEVEL_HIGH>,
@@ -1419,7 +1419,7 @@ uart7: serial@99c000 {

gpi_dma1: dma-controller@a00000 {
#dma-cells = <3>;
- compatible = "qcom,sc7280-gpi-dma";
+ compatible = "qcom,sc7280-gpi-dma", "qcom,sm6350-gpi-dma";
reg = <0 0x00a00000 0 0x60000>;
interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 280 IRQ_TYPE_LEVEL_HIGH>,
--
2.34.1

2022-10-18 23:37:57

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH v2 5/5] arm64: dts: qcom: sm8450: Add GPI DMA compatible fallback

Use SM6350 as fallback for GPI DMA, to indicate devices are compatible
and that drivers can bind with only one compatible.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Neil Armstrong <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index d32f08df743d..e01a019d8b23 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -730,7 +730,7 @@ gcc: clock-controller@100000 {
};

gpi_dma2: dma-controller@800000 {
- compatible = "qcom,sm8450-gpi-dma";
+ compatible = "qcom,sm8450-gpi-dma", "qcom,sm6350-gpi-dma";
#dma-cells = <3>;
reg = <0 0x800000 0 0x60000>;
interrupts = <GIC_SPI 588 IRQ_TYPE_LEVEL_HIGH>,
@@ -1058,7 +1058,7 @@ spi21: spi@898000 {
};

gpi_dma0: dma-controller@900000 {
- compatible = "qcom,sm8450-gpi-dma";
+ compatible = "qcom,sm8450-gpi-dma", "qcom,sm6350-gpi-dma";
#dma-cells = <3>;
reg = <0 0x900000 0 0x60000>;
interrupts = <GIC_SPI 244 IRQ_TYPE_LEVEL_HIGH>,
@@ -1394,7 +1394,7 @@ uart7: serial@99c000 {
};

gpi_dma1: dma-controller@a00000 {
- compatible = "qcom,sm8450-gpi-dma";
+ compatible = "qcom,sm8450-gpi-dma", "qcom,sm6350-gpi-dma";
#dma-cells = <3>;
reg = <0 0xa00000 0 0x60000>;
interrupts = <GIC_SPI 279 IRQ_TYPE_LEVEL_HIGH>,
--
2.34.1

2022-10-19 13:58:26

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH v2 0/5] dma/arm64: qcom: use one compatible also for 0x10000 offset

On 18-10-22, 19:03, Krzysztof Kozlowski wrote:
> Hi,
>
> Dependencies
> ============
> 1. DT bindings and DMA driver change depends contextually on:
> https://lore.kernel.org/all/[email protected]/
>
> 2. DTS patches are independent, although they will spark some dtbs_check
> warnings (due to change in bindings).

Applied 1-2, thanks

--
~Vinod

2022-11-07 03:35:15

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH v2 0/5] dma/arm64: qcom: use one compatible also for 0x10000 offset

On Tue, 18 Oct 2022 19:03:47 -0400, Krzysztof Kozlowski wrote:
> Changes since v1
> ================
> 1. Rebase on v6 of Richard's patch.
> 2. Add tags.
>
> Dependencies
> ============
> 1. DT bindings and DMA driver change depends contextually on:
> https://lore.kernel.org/all/[email protected]/
>
> [...]

Applied, thanks!

[3/5] arm64: dts: qcom: sc7280: Add GPI DMA compatible fallback
commit: e9f2053b7866ac09f2acebbe65056204ef3fe67d
[4/5] arm64: dts: qcom: sm8350: Add GPI DMA compatible fallback
commit: b561e225dee5412609fd98340ca71ba0ab2e4b36
[5/5] arm64: dts: qcom: sm8450: Add GPI DMA compatible fallback
commit: 19e67894500a8a038cb103e7267da5e64bcc853c

Best regards,
--
Bjorn Andersson <[email protected]>