Reporter health_state is set twice to error in devlink_health_report().
Remove second time as it is redundant.
Signed-off-by: Moshe Shemesh <[email protected]>
Reviewed-by: Eran Ben Elisha <[email protected]>
---
net/core/devlink.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/devlink.c b/net/core/devlink.c
index d93bc95cd7cb..cea154ddce7a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -7846,8 +7846,6 @@ int devlink_health_report(struct devlink_health_reporter *reporter,
return -ECANCELED;
}
- reporter->health_state = DEVLINK_HEALTH_REPORTER_STATE_ERROR;
-
if (reporter->auto_dump) {
mutex_lock(&reporter->dump_lock);
/* store current dump of current error, for later analysis */
--
2.26.3
On Sun, Nov 20, 2022 at 10:36:52AM +0200, Moshe Shemesh wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
>
> Signed-off-by: Moshe Shemesh <[email protected]>
> Reviewed-by: Eran Ben Elisha <[email protected]>
> ---
> net/core/devlink.c | 2 --
> 1 file changed, 2 deletions(-)
>
Thanks,
Reviewed-by: Leon Romanovsky <[email protected]>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Sun, 20 Nov 2022 10:36:52 +0200 you wrote:
> Reporter health_state is set twice to error in devlink_health_report().
> Remove second time as it is redundant.
>
> Signed-off-by: Moshe Shemesh <[email protected]>
> Reviewed-by: Eran Ben Elisha <[email protected]>
> ---
> net/core/devlink.c | 2 --
> 1 file changed, 2 deletions(-)
Here is the summary with links:
- [net-next] devlink: remove redundant health state set to error
https://git.kernel.org/netdev/net-next/c/815bc3ac75e9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html