2022-11-22 11:16:00

by Zhang Changzhong

Subject: [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()

If prestera_port_sfp_bind() fails, unregister_netdev() should be called
in error handling path.

Compile tested only.

Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
Signed-off-by: Zhang Changzhong <[email protected]>
---
drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
index 24f9d60..47796e4 100644
--- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
+++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
@@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
return 0;

err_sfp_bind:
+ unregister_netdev(dev);
err_register_netdev:
prestera_port_list_del(port);
err_port_init:
--
2.9.5

2022-11-22 12:41:10

by Maciej Fijalkowski

Subject: Re: [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()

On Tue, Nov 22, 2022 at 07:10:31PM +0800, Zhang Changzhong wrote:
> If prestera_port_sfp_bind() fails, unregister_netdev() should be called
> in error handling path.
>
> Compile tested only.
>
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Zhang Changzhong <[email protected]>

Makes sense and fixes commit is correct.
Reviewed-by: Maciej Fijalkowski <[email protected]>

> ---
> drivers/net/ethernet/marvell/prestera/prestera_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> index 24f9d60..47796e4 100644
> --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c
> +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c
> @@ -746,6 +746,7 @@ static int prestera_port_create(struct prestera_switch *sw, u32 id)
> return 0;
>
> err_sfp_bind:
> + unregister_netdev(dev);
> err_register_netdev:
> prestera_port_list_del(port);
> err_port_init:
> --
> 2.9.5
>

2022-11-24 04:52:45

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 22 Nov 2022 19:10:31 +0800 you wrote:
> If prestera_port_sfp_bind() fails, unregister_netdev() should be called
> in error handling path.
>
> Compile tested only.
>
> Fixes: 52323ef75414 ("net: marvell: prestera: add phylink support")
> Signed-off-by: Zhang Changzhong <[email protected]>
>
> [...]

Here is the summary with links:
- [net] net: marvell: prestera: add missing unregister_netdev() in prestera_port_create()
https://git.kernel.org/netdev/net/c/9a234a2a085a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html