2022-03-17 06:45:43

by baihaowen

Subject: [PATCH] macintosh: windfarm_pm81: Fix warning comparing pointer to 0

Avoid pointer type value compared with 0 to make code clear.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/macintosh/windfarm_pm81.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/windfarm_pm81.c b/drivers/macintosh/windfarm_pm81.c
index 82c67a4..1dfced5 100644
--- a/drivers/macintosh/windfarm_pm81.c
+++ b/drivers/macintosh/windfarm_pm81.c
@@ -400,7 +400,7 @@ static void wf_smu_create_cpu_fans(void)

/* First, locate the PID params in SMU SBD */
hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
- if (hdr == 0) {
+ if (!hdr) {
printk(KERN_WARNING "windfarm: CPU PID fan config not found "
"max fan speed\n");
goto fail;
@@ -704,7 +704,7 @@ static int wf_init_pm(void)
const struct smu_sdbp_header *hdr;

hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
- if (hdr != 0) {
+ if (hdr) {
struct smu_sdbp_sensortree *st =
(struct smu_sdbp_sensortree *)&hdr[1];
wf_smu_mach_model = st->model_id;
--
2.7.4

2022-11-30 10:45:57

by Michael Ellerman

Subject: Re: [PATCH] macintosh: windfarm_pm81: Fix warning comparing pointer to 0

On Thu, 17 Mar 2022 10:32:39 +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
>
>

Applied to powerpc/next.

[1/1] macintosh: windfarm_pm81: Fix warning comparing pointer to 0
https://git.kernel.org/powerpc/c/e0acfdd13474815696595206e11169736b4bca9d

cheers