2022-03-17 06:33:29

by baihaowen

Subject: [PATCH] macintosh: windfarm_pm121: Fix warning comparing pointer to 0

Avoid pointer type value compared with 0 to make code clear.

Signed-off-by: Haowen Bai <[email protected]>
---
drivers/macintosh/windfarm_pm121.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/macintosh/windfarm_pm121.c b/drivers/macintosh/windfarm_pm121.c
index ba1ec6f..f0aa263 100644
--- a/drivers/macintosh/windfarm_pm121.c
+++ b/drivers/macintosh/windfarm_pm121.c
@@ -650,7 +650,7 @@ static void pm121_create_cpu_fans(void)

/* First, locate the PID params in SMU SBD */
hdr = smu_get_sdb_partition(SMU_SDB_CPUPIDDATA_ID, NULL);
- if (hdr == 0) {
+ if (!hdr) {
printk(KERN_WARNING "pm121: CPU PID fan config not found.\n");
goto fail;
}
@@ -969,7 +969,7 @@ static int pm121_init_pm(void)
const struct smu_sdbp_header *hdr;

hdr = smu_get_sdb_partition(SMU_SDB_SENSORTREE_ID, NULL);
- if (hdr != 0) {
+ if (hdr) {
struct smu_sdbp_sensortree *st =
(struct smu_sdbp_sensortree *)&hdr[1];
pm121_mach_model = st->model_id;
--
2.7.4

2022-11-30 10:21:53

by Michael Ellerman

Subject: Re: [PATCH] macintosh: windfarm_pm121: Fix warning comparing pointer to 0

On Thu, 17 Mar 2022 10:57:02 +0800, Haowen Bai wrote:
> Avoid pointer type value compared with 0 to make code clear.
>
>

Applied to powerpc/next.

[1/1] macintosh: windfarm_pm121: Fix warning comparing pointer to 0
https://git.kernel.org/powerpc/c/a823307bf0a3b79b27eea916bf6499ba4377cdf9

cheers