2022-11-16 11:35:34

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 0/2] soc: rpmhpd: Add support for SM8550

This patchset adds RPMh power domains support for the new
Qualcomm SM8550 SoC.

To: Andy Gross <[email protected]>
To: Bjorn Andersson <[email protected]>
To: Konrad Dybcio <[email protected]>
To: Rob Herring <[email protected]>
To: Krzysztof Kozlowski <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]

Abel Vesa (2):
dt-bindings: power: rpmpd: Add SM8550 to rpmpd binding
soc: qcom: rpmhpd: Add SM8550 power domains

.../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
drivers/soc/qcom/rpmhpd.c | 24 +++++++++++++++++++
include/dt-bindings/power/qcom-rpmpd.h | 16 +++++++++++++
3 files changed, 41 insertions(+)

--
2.34.1



2022-11-16 11:49:27

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 2/2] soc: qcom: rpmhpd: Add SM8550 power domains

Add the power domains exposed by RPMH in the Qualcomm SM8550 platform.

Signed-off-by: Abel Vesa <[email protected]>
---
drivers/soc/qcom/rpmhpd.c | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
index 7af68cd720f5..4c2d2c296790 100644
--- a/drivers/soc/qcom/rpmhpd.c
+++ b/drivers/soc/qcom/rpmhpd.c
@@ -372,6 +372,29 @@ static const struct rpmhpd_desc sm8450_desc = {
.num_pds = ARRAY_SIZE(sm8450_rpmhpds),
};

+/* SM8550 RPMH powerdomains */
+static struct rpmhpd *sm8550_rpmhpds[] = {
+ [SM8550_CX] = &cx,
+ [SM8550_CX_AO] = &cx_ao,
+ [SM8550_EBI] = &ebi,
+ [SM8550_GFX] = &gfx,
+ [SM8550_LCX] = &lcx,
+ [SM8550_LMX] = &lmx,
+ [SM8550_MMCX] = &mmcx_w_cx_parent,
+ [SM8550_MMCX_AO] = &mmcx_ao_w_cx_parent,
+ [SM8550_MSS] = &mss,
+ [SM8550_MX] = &mx,
+ [SM8550_MX_AO] = &mx_ao,
+ [SM8550_MXC] = &mxc,
+ [SM8550_MXC_AO] = &mxc_ao,
+ [SM8550_NSP] = &nsp,
+};
+
+static const struct rpmhpd_desc sm8550_desc = {
+ .rpmhpds = sm8550_rpmhpds,
+ .num_pds = ARRAY_SIZE(sm8550_rpmhpds),
+};
+
/* QDU1000/QRU1000 RPMH powerdomains */
static struct rpmhpd *qdu1000_rpmhpds[] = {
[QDU1000_CX] = &cx,
@@ -477,6 +500,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
{ .compatible = "qcom,sm8250-rpmhpd", .data = &sm8250_desc },
{ .compatible = "qcom,sm8350-rpmhpd", .data = &sm8350_desc },
{ .compatible = "qcom,sm8450-rpmhpd", .data = &sm8450_desc },
+ { .compatible = "qcom,sm8550-rpmhpd", .data = &sm8550_desc },
{ }
};
MODULE_DEVICE_TABLE(of, rpmhpd_match_table);
--
2.34.1


2022-11-16 11:52:57

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] soc: qcom: rpmhpd: Add SM8550 power domains



On 16/11/2022 12:17, Abel Vesa wrote:
> Add the power domains exposed by RPMH in the Qualcomm SM8550 platform.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/soc/qcom/rpmhpd.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/soc/qcom/rpmhpd.c b/drivers/soc/qcom/rpmhpd.c
> index 7af68cd720f5..4c2d2c296790 100644
> --- a/drivers/soc/qcom/rpmhpd.c
> +++ b/drivers/soc/qcom/rpmhpd.c
> @@ -372,6 +372,29 @@ static const struct rpmhpd_desc sm8450_desc = {
> .num_pds = ARRAY_SIZE(sm8450_rpmhpds),
> };
>
> +/* SM8550 RPMH powerdomains */
> +static struct rpmhpd *sm8550_rpmhpds[] = {
> + [SM8550_CX] = &cx,
> + [SM8550_CX_AO] = &cx_ao,
> + [SM8550_EBI] = &ebi,
> + [SM8550_GFX] = &gfx,
> + [SM8550_LCX] = &lcx,
> + [SM8550_LMX] = &lmx,
> + [SM8550_MMCX] = &mmcx_w_cx_parent,
> + [SM8550_MMCX_AO] = &mmcx_ao_w_cx_parent,
> + [SM8550_MSS] = &mss,
> + [SM8550_MX] = &mx,
> + [SM8550_MX_AO] = &mx_ao,
> + [SM8550_MXC] = &mxc,
> + [SM8550_MXC_AO] = &mxc_ao,
> + [SM8550_NSP] = &nsp,
> +};
> +
> +static const struct rpmhpd_desc sm8550_desc = {
> + .rpmhpds = sm8550_rpmhpds,
> + .num_pds = ARRAY_SIZE(sm8550_rpmhpds),
> +};
> +
> /* QDU1000/QRU1000 RPMH powerdomains */
> static struct rpmhpd *qdu1000_rpmhpds[] = {
> [QDU1000_CX] = &cx,
> @@ -477,6 +500,7 @@ static const struct of_device_id rpmhpd_match_table[] = {
> { .compatible = "qcom,sm8250-rpmhpd", .data = &sm8250_desc },
> { .compatible = "qcom,sm8350-rpmhpd", .data = &sm8350_desc },
> { .compatible = "qcom,sm8450-rpmhpd", .data = &sm8450_desc },
> + { .compatible = "qcom,sm8550-rpmhpd", .data = &sm8550_desc },
> { }
> };
> MODULE_DEVICE_TABLE(of, rpmhpd_match_table);

2022-11-16 12:03:24

by Abel Vesa

[permalink] [raw]
Subject: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM8550 to rpmpd binding

Add compatible and constants for the power domains exposed by the RPMH
in the Qualcomm SM8550 platform.

Signed-off-by: Abel Vesa <[email protected]>
---
.../devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 16 ++++++++++++++++
2 files changed, 17 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
index c0bee4e8a9db..5bb9f59d196f 100644
--- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
+++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml
@@ -47,6 +47,7 @@ properties:
- qcom,sm8250-rpmhpd
- qcom,sm8350-rpmhpd
- qcom,sm8450-rpmhpd
+ - qcom,sm8550-rpmhpd

'#power-domain-cells':
const: 1
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 7b2e4b66419a..7a31620ede7f 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -113,6 +113,22 @@
#define SM8450_MXC_AO 11
#define SM8450_MSS 12

+/* SM8550 Power Domain Indexes */
+#define SM8550_CX 0
+#define SM8550_CX_AO 1
+#define SM8550_EBI 2
+#define SM8550_GFX 3
+#define SM8550_LCX 4
+#define SM8550_LMX 5
+#define SM8550_MMCX 6
+#define SM8550_MMCX_AO 7
+#define SM8550_MX 8
+#define SM8550_MX_AO 9
+#define SM8550_MXC 10
+#define SM8550_MXC_AO 11
+#define SM8550_MSS 12
+#define SM8550_NSP 13
+
/* QDU1000/QRU1000 Power Domain Indexes */
#define QDU1000_EBI 0
#define QDU1000_MSS 1
--
2.34.1


2022-11-16 12:23:16

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: power: rpmpd: Add SM8550 to rpmpd binding

On 16/11/2022 12:17, Abel Vesa wrote:
> Add compatible and constants for the power domains exposed by the RPMH
> in the Qualcomm SM8550 platform.
>
> Signed-off-by: Abel Vesa <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof


2022-12-06 18:32:56

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] soc: rpmhpd: Add support for SM8550

On Wed, 16 Nov 2022 13:17:43 +0200, Abel Vesa wrote:
> This patchset adds RPMh power domains support for the new
> Qualcomm SM8550 SoC.
>
> To: Andy Gross <[email protected]>
> To: Bjorn Andersson <[email protected]>
> To: Konrad Dybcio <[email protected]>
> To: Rob Herring <[email protected]>
> To: Krzysztof Kozlowski <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
>
> [...]

Applied, thanks!

[1/2] dt-bindings: power: rpmpd: Add SM8550 to rpmpd binding
commit: f0f4727a12e4a2e8d1ab788abbfa357994f5d681
[2/2] soc: qcom: rpmhpd: Add SM8550 power domains
commit: d1d9d62bd484279511c08c8db07602f130a43ad9

Best regards,
--
Bjorn Andersson <[email protected]>