2022-11-23 02:56:08

by liao jaime

Subject: [PATCH] memory: renesas-rpc-if: Fix missing setting address

In the RPC manual mode, if the data direction is not set
(such as the flash erase command), the address misses the
setting.

Signed-off-by: JaimeLiao <[email protected]>
---
drivers/memory/renesas-rpc-if.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/memory/renesas-rpc-if.c b/drivers/memory/renesas-rpc-if.c
index 4316988d791a..bdf0a7f68ff2 100644
--- a/drivers/memory/renesas-rpc-if.c
+++ b/drivers/memory/renesas-rpc-if.c
@@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
}
break;
default:
+ regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
regmap_write(rpc->regmap, RPCIF_SMCR,
rpc->smcr | RPCIF_SMCR_SPIE);
--
2.17.1

2022-12-27 09:29:46

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.
>
>

Applied, thanks!

[1/1] memory: renesas-rpc-if: Fix missing setting address
https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3

Best regards,
--
Krzysztof Kozlowski <[email protected]>

2023-01-23 10:45:20

by Geert Uytterhoeven

Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

Hi Jaime,

CC linux-renesas-soc

Thanks for your patch!

On Wed, Nov 23, 2022 at 3:55 AM JaimeLiao <[email protected]> wrote:
> In the RPC manual mode, if the data direction is not set
> (such as the flash erase command), the address misses the
> setting.

This patch never received review comments.
As of commit fff53a551db50f5e ("memory: renesas-rpc-if: Correct QSPI
data transfer in Manual mode") in v5.16-rc1, RPCIF_SMADR is written
before the switch() statement, hence this patch can be ignored.

See also
https://lore.kernel.org/all/CAMuHMdWpvuC2Cm41jCQm+rT8MZB5GN+Z0bPz941QzsHX17Ux-g@mail.gmail.com

> Signed-off-by: JaimeLiao <[email protected]>

> --- a/drivers/memory/renesas-rpc-if.c
> +++ b/drivers/memory/renesas-rpc-if.c
> @@ -571,6 +571,7 @@ int rpcif_manual_xfer(struct rpcif *rpc)
> }
> break;
> default:
> + regmap_write(rpc->regmap, RPCIF_SMADR, rpc->smadr);
> regmap_write(rpc->regmap, RPCIF_SMENR, rpc->enable);
> regmap_write(rpc->regmap, RPCIF_SMCR,
> rpc->smcr | RPCIF_SMCR_SPIE);

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds

2023-01-23 10:47:32

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: renesas-rpc-if: Fix missing setting address

On 27/12/2022 09:59, Krzysztof Kozlowski wrote:
> On Wed, 23 Nov 2022 10:51:41 +0800, JaimeLiao wrote:
>> In the RPC manual mode, if the data direction is not set
>> (such as the flash erase command), the address misses the
>> setting.
>>
>>
>
> Applied, thanks!
>
> [1/1] memory: renesas-rpc-if: Fix missing setting address
> https://git.kernel.org/krzk/linux-mem-ctrl/c/21a1234f82cbf4258445072bb23c38fed2ce6cb3

And drop. Stop sending the same patch all over again...

Best regards,
Krzysztof