2022-11-26 05:10:58

by Gaosheng Cui

Subject: [PATCH] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()

The clk_disable_unprepare() should be called in the error handling
of devbus_get_timing_params() and of_platform_populate(), fix it by
replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled.

Fixes: e81b6abebc87 ("memory: add a driver for atmel ram controllers")
Signed-off-by: Gaosheng Cui <[email protected]>
---
drivers/memory/mvebu-devbus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/memory/mvebu-devbus.c b/drivers/memory/mvebu-devbus.c
index 8450638e8670..efc6c08db2b7 100644
--- a/drivers/memory/mvebu-devbus.c
+++ b/drivers/memory/mvebu-devbus.c
@@ -280,10 +280,9 @@ static int mvebu_devbus_probe(struct platform_device *pdev)
if (IS_ERR(devbus->base))
return PTR_ERR(devbus->base);

- clk = devm_clk_get(&pdev->dev, NULL);
+ clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(clk))
return PTR_ERR(clk);
- clk_prepare_enable(clk);

/*
* Obtain clock period in picoseconds,
--
2.25.1

2022-12-27 09:14:07

by Krzysztof Kozlowski

Subject: Re: [PATCH] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()

On Sat, 26 Nov 2022 12:49:11 +0800, Gaosheng Cui wrote:
> The clk_disable_unprepare() should be called in the error handling
> of devbus_get_timing_params() and of_platform_populate(), fix it by
> replacing devm_clk_get and clk_prepare_enable by devm_clk_get_enabled.
>
>

Applied, thanks!

[1/1] memory: mvebu-devbus: Fix missing clk_disable_unprepare in mvebu_devbus_probe()
https://git.kernel.org/krzk/linux-mem-ctrl/c/cb8fd6f75775165390ededea8799b60d93d9fe3e

Best regards,
--
Krzysztof Kozlowski <[email protected]>