The function __b44_cam_read() is defined in the b44.c file, but not called
elsewhere, so remove this unused function.
drivers/net/ethernet/broadcom/b44.c:199:20: warning: unused function '__b44_cam_read'.
Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3858
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/ethernet/broadcom/b44.c | 22 ----------------------
1 file changed, 22 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
index b751dc8486dc..392ec09a1d8a 100644
--- a/drivers/net/ethernet/broadcom/b44.c
+++ b/drivers/net/ethernet/broadcom/b44.c
@@ -196,28 +196,6 @@ static int b44_wait_bit(struct b44 *bp, unsigned long reg,
return 0;
}
-static inline void __b44_cam_read(struct b44 *bp, unsigned char *data, int index)
-{
- u32 val;
-
- bw32(bp, B44_CAM_CTRL, (CAM_CTRL_READ |
- (index << CAM_CTRL_INDEX_SHIFT)));
-
- b44_wait_bit(bp, B44_CAM_CTRL, CAM_CTRL_BUSY, 100, 1);
-
- val = br32(bp, B44_CAM_DATA_LO);
-
- data[2] = (val >> 24) & 0xFF;
- data[3] = (val >> 16) & 0xFF;
- data[4] = (val >> 8) & 0xFF;
- data[5] = (val >> 0) & 0xFF;
-
- val = br32(bp, B44_CAM_DATA_HI);
-
- data[0] = (val >> 8) & 0xFF;
- data[1] = (val >> 0) & 0xFF;
-}
-
static inline void __b44_cam_write(struct b44 *bp,
const unsigned char *data, int index)
{
--
2.20.1.7.g153144c
On Sat, Jan 28, 2023 at 05:04:13PM +0800, Jiapeng Chong wrote:
> The function __b44_cam_read() is defined in the b44.c file, but not called
> elsewhere, so remove this unused function.
>
> drivers/net/ethernet/broadcom/b44.c:199:20: warning: unused function '__b44_cam_read'.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3858
> Signed-off-by: Jiapeng Chong <[email protected]>
Thanks,
This seems to have been the case since '__b44_cam_read' was
created via some refactoring in 2007 by
753f492093da ("[B44]: port to native ssb support")
But I'm not sure this warrants a fixes tag.
Reviewed-by: Simon Horman <[email protected]>
Hello:
This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:
On Sat, 28 Jan 2023 17:04:13 +0800 you wrote:
> The function __b44_cam_read() is defined in the b44.c file, but not called
> elsewhere, so remove this unused function.
>
> drivers/net/ethernet/broadcom/b44.c:199:20: warning: unused function '__b44_cam_read'.
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3858
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]
Here is the summary with links:
- net: b44: Remove the unused function __b44_cam_read()
https://git.kernel.org/netdev/net-next/c/1586f31e30ed
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html