Bindings expect (and most of DTS use) the RPM G-Link node name to be
"rpm-requests".
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
index d32c9b2515ee..bbd94025ff5d 100644
--- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi
@@ -176,7 +176,7 @@ rpm-glink {
qcom,rpm-msg-ram = <&rpm_msg_ram>;
mboxes = <&apcs_glb 0>;
- rpm_requests: glink-channel {
+ rpm_requests: rpm-requests {
compatible = "qcom,rpm-ipq6018";
qcom,glink-channels = "rpm_requests";
--
2.34.1
Bindings expect (and most of DTS use) the RPM G-Link node name to be
"rpm-requests".
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/qcs404.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi b/arch/arm64/boot/dts/qcom/qcs404.dtsi
index 9c9890cf1b10..bc2ed73afb74 100644
--- a/arch/arm64/boot/dts/qcom/qcs404.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi
@@ -223,7 +223,7 @@ rpm-glink {
qcom,rpm-msg-ram = <&rpm_msg_ram>;
mboxes = <&apcs_glb 0>;
- rpm_requests: glink-channel {
+ rpm_requests: rpm-requests {
compatible = "qcom,rpm-qcs404";
qcom,glink-channels = "rpm_requests";
--
2.34.1
qcom,rpmcc bindings expect RPM clock controller to be named generic
"clock-controller":
rpm-glink: rpm-requests: 'qcom,rpmcc' does not match any of the regexes: '^regulators(-[01])?$', 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Dmitry Baryshkov <[email protected]>
---
Changes since v1:
1. Add Rb tag.
---
arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index 55180586f7b6..e0d46dbd498f 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -483,7 +483,7 @@ rpm_requests: rpm-requests {
compatible = "qcom,rpm-msm8996";
qcom,glink-channels = "rpm_requests";
- rpmcc: qcom,rpmcc {
+ rpmcc: clock-controller {
compatible = "qcom,rpmcc-msm8996", "qcom,rpmcc";
#clock-cells = <1>;
clocks = <&xo_board>;
--
2.34.1
The qcom,intents property is a list of pairs, thus it should be defined
as uint32-matrix.
Fixes: b2d7616e13c4 ("dt-bindings: soc: qcom: apr: add missing properties")
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. New patch
---
Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
index 6026c21736d8..4502458b0669 100644
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
+++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml
@@ -62,7 +62,14 @@ properties:
maxItems: 1
qcom,intents:
- $ref: /schemas/types.yaml#/definitions/uint32-array
+ $ref: /schemas/types.yaml#/definitions/uint32-matrix
+ minItems: 1
+ maxItems: 32
+ items:
+ items:
+ - description: size of each intent to preallocate
+ - description: amount of intents to preallocate
+ minimum: 1
description:
List of (size, amount) pairs describing what intents should be
preallocated for this virtual channel. This can be used to tweak the
--
2.34.1
Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names
property.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. None.
2. Previously was sent as separate patch.
There are no strict dependencies. This can go anytime. The next patch
(glink-rpm-edge) should be applied in the same or later cycle (could be
via different trees).
---
.../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 -
1 file changed, 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
index 943f9472ae10..56b386b688b3 100644
--- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
+++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
@@ -155,7 +155,6 @@ examples:
interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
qcom,rpm-msg-ram = <&rpm_msg_ram>;
mboxes = <&apcs_glb 0>;
- mbox-names = "rpm_hlos";
};
# Example apcs with qcs404
--
2.34.1
Convert Qualcomm G-Link RPM edge binding to DT schema. Move it to
remoteproc as it better suits the purpose - communication channel with
remote processor.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. :: -> :
2. Correct qcom,intents type.
There are no strict dependencies on other patches, but the previous
"qcom,apcs-kpss-global" should end up in the same cycle (or earlier) as
this one.
---
.../remoteproc/qcom,glink-rpm-edge.yaml | 99 +++++++++++++++++++
.../bindings/soc/qcom/qcom,glink.txt | 94 ------------------
2 files changed, 99 insertions(+), 94 deletions(-)
create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml
delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml
new file mode 100644
index 000000000000..f5a044e20c4e
--- /dev/null
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml
@@ -0,0 +1,99 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/remoteproc/qcom,glink-rpm-edge.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm G-Link RPM edge
+
+description: |
+ Qualcomm G-Link edge, a FIFO based mechanism for communication with Resource
+ Power Manager (RPM) on various Qualcomm platforms.
+
+maintainers:
+ - Bjorn Andersson <[email protected]>
+
+properties:
+ compatible:
+ const: qcom,glink-rpm
+
+ label:
+ $ref: /schemas/types.yaml#/definitions/string
+ description:
+ Name of the edge, used for debugging and identification purposes. The
+ node name will be used if this is not present.
+
+ interrupts:
+ maxItems: 1
+
+ mboxes:
+ items:
+ - description: rpm_hlos mailbox in APCS
+
+ qcom,remote-pid:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ The identifier for the remote processor as known by the rest of the
+ system.
+
+ qcom,rpm-msg-ram:
+ $ref: /schemas/types.yaml#/definitions/phandle
+ description: |
+ RPM message memory resource (compatible: qcom,rpm-msg-ram).
+
+ rpm-requests:
+ type: object
+ $ref: /schemas/soc/qcom/qcom,smd-rpm.yaml#
+ unevaluatedProperties: false
+ description:
+ Qualcomm Resource Power Manager (RPM) over G-Link
+
+ properties:
+ qcom,intents:
+ $ref: /schemas/types.yaml#/definitions/uint32-matrix
+ minItems: 1
+ maxItems: 32
+ items:
+ items:
+ - description: size of each intent to preallocate
+ - description: amount of intents to preallocate
+ minimum: 1
+ description:
+ List of (size, amount) pairs describing what intents should be
+ preallocated for this virtual channel. This can be used to tweak the
+ default intents available for the channel to meet expectations of the
+ remote.
+
+ required:
+ - qcom,glink-channels
+
+required:
+ - compatible
+ - interrupts
+ - mboxes
+
+anyOf:
+ - required:
+ - qcom,remote-pid
+ - required:
+ - qcom,rpm-msg-ram
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ rpm-glink {
+ compatible = "qcom,glink-rpm";
+ interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
+ mboxes = <&apcs_glb 0>;
+ qcom,rpm-msg-ram = <&rpm_msg_ram>;
+
+ rpm-requests {
+ compatible = "qcom,rpm-msm8996";
+ qcom,glink-channels = "rpm_requests";
+
+ /* ... */
+ };
+ };
diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
deleted file mode 100644
index 1214192847ac..000000000000
--- a/Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
+++ /dev/null
@@ -1,94 +0,0 @@
-Qualcomm GLINK edge binding
-
-This binding describes a Qualcomm GLINK edge, a fifo based mechanism for
-communication between subsystem-pairs on various Qualcomm platforms. Two types
-of edges can be described by the binding; the GLINK RPM edge and a SMEM based
-edge.
-
-- compatible:
- Usage: required for glink-rpm
- Value type: <stringlist>
- Definition: must be "qcom,glink-rpm"
-
-- label:
- Usage: optional
- Value type: <string>
- Definition: should specify the subsystem name this edge corresponds to.
-
-- interrupts:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: should specify the IRQ used by the remote processor to
- signal this processor about communication related events
-
-- qcom,remote-pid:
- Usage: required for glink-smem
- Value type: <u32>
- Definition: specifies the identifier of the remote endpoint of this edge
-
-- qcom,rpm-msg-ram:
- Usage: required for glink-rpm
- Value type: <prop-encoded-array>
- Definition: handle to RPM message memory resource
-
-- mboxes:
- Usage: required
- Value type: <prop-encoded-array>
- Definition: reference to the "rpm_hlos" mailbox in APCS, as described
- in mailbox/mailbox.txt
-
-= GLINK DEVICES
-Each subnode of the GLINK node represent function tied to a virtual
-communication channel. The name of the nodes are not important. The properties
-of these nodes are defined by the individual bindings for the specific function
-- but must contain the following property:
-
-- qcom,glink-channels:
- Usage: required
- Value type: <stringlist>
- Definition: a list of channels tied to this function, used for matching
- the function to a set of virtual channels
-
-- qcom,intents:
- Usage: optional
- Value type: <prop-encoded-array>
- Definition: a list of size,amount pairs describing what intents should
- be preallocated for this virtual channel. This can be used
- to tweak the default intents available for the channel to
- meet expectations of the remote.
-
-= EXAMPLE
-The following example represents the GLINK RPM node on a MSM8996 device, with
-the function for the "rpm_request" channel defined, which is used for
-regulators and root clocks.
-
- apcs_glb: mailbox@9820000 {
- compatible = "qcom,msm8996-apcs-hmss-global";
- reg = <0x9820000 0x1000>;
-
- #mbox-cells = <1>;
- };
-
- rpm_msg_ram: memory@68000 {
- compatible = "qcom,rpm-msg-ram";
- reg = <0x68000 0x6000>;
- };
-
- rpm-glink {
- compatible = "qcom,glink-rpm";
-
- interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
-
- qcom,rpm-msg-ram = <&rpm_msg_ram>;
-
- mboxes = <&apcs_glb 0>;
-
- rpm-requests {
- compatible = "qcom,rpm-msm8996";
- qcom,glink-channels = "rpm_requests";
-
- qcom,intents = <0x400 5
- 0x800 1>;
- ...
- };
- };
--
2.34.1
Correct the description of 'label' property.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Changes since v1:
1. None
---
.../devicetree/bindings/remoteproc/qcom,glink-edge.yaml | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
index 8e133ab55ff3..15e6851e1ff8 100644
--- a/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
+++ b/Documentation/devicetree/bindings/remoteproc/qcom,glink-edge.yaml
@@ -42,7 +42,9 @@ properties:
maxItems: 1
label:
- description: The names of the state bits used for SMP2P output
+ description:
+ Name of the edge, used for debugging and identification purposes. The
+ node name will be used if this is not present.
mboxes:
maxItems: 1
--
2.34.1
On Wed, 08 Feb 2023 11:15:42 +0100, Krzysztof Kozlowski wrote:
> Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names
> property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None.
> 2. Previously was sent as separate patch.
>
> There are no strict dependencies. This can go anytime. The next patch
> (glink-rpm-edge) should be applied in the same or later cycle (could be
> via different trees).
> ---
> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Wed, 08 Feb 2023 11:15:43 +0100, Krzysztof Kozlowski wrote:
> The qcom,intents property is a list of pairs, thus it should be defined
> as uint32-matrix.
>
> Fixes: b2d7616e13c4 ("dt-bindings: soc: qcom: apr: add missing properties")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. New patch
> ---
> Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Wed, 08 Feb 2023 11:15:44 +0100, Krzysztof Kozlowski wrote:
> Convert Qualcomm G-Link RPM edge binding to DT schema. Move it to
> remoteproc as it better suits the purpose - communication channel with
> remote processor.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. :: -> :
> 2. Correct qcom,intents type.
>
> There are no strict dependencies on other patches, but the previous
> "qcom,apcs-kpss-global" should end up in the same cycle (or earlier) as
> this one.
> ---
> .../remoteproc/qcom,glink-rpm-edge.yaml | 99 +++++++++++++++++++
> .../bindings/soc/qcom/qcom,glink.txt | 94 ------------------
> 2 files changed, 99 insertions(+), 94 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,glink-rpm-edge.yaml
> delete mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,glink.txt
>
Acked-by: Rob Herring <[email protected]>
On Wed, 08 Feb 2023 11:15:45 +0100, Krzysztof Kozlowski wrote:
> Correct the description of 'label' property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None
> ---
> .../devicetree/bindings/remoteproc/qcom,glink-edge.yaml | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <[email protected]>
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
> Bindings expect (and most of DTS use) the RPM G-Link node name to be
> "rpm-requests".
>
>
Applied, thanks!
[1/7] arm64: dts: qcom: ipq6018: align RPM G-Link node with bindings
commit: 679ee73bbee28cab441008f8cca38160cc8f3d05
[2/7] arm64: dts: qcom: qcs404: align RPM G-Link node with bindings
commit: 7bf30eb441b3bdaa368e65837a03f9fbba033180
[3/7] arm64: dts: qcom: msm8996: align RPM G-Link clock-controller node with bindings
commit: 407ef897bd0275e38ae33d410857e71c092679bd
Best regards,
--
Bjorn Andersson <[email protected]>
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
> Bindings expect (and most of DTS use) the RPM G-Link node name to be
> "rpm-requests".
>
>
Applied, thanks!
[6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema
commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0
[7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description
commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813
Best regards,
--
Bjorn Andersson <[email protected]>
On Wed, Feb 8, 2023 at 4:16 AM Krzysztof Kozlowski
<[email protected]> wrote:
>
> Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names
> property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None.
> 2. Previously was sent as separate patch.
>
> There are no strict dependencies. This can go anytime. The next patch
> (glink-rpm-edge) should be applied in the same or later cycle (could be
> via different trees).
Except that without this patch there is now a warning in linux-next.
Rob
On Tue, Feb 14, 2023 at 11:28 AM Bjorn Andersson <[email protected]> wrote:
>
> On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
> > Bindings expect (and most of DTS use) the RPM G-Link node name to be
> > "rpm-requests".
> >
> >
>
> Applied, thanks!
>
> [6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema
> commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0
> [7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description
> commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813
You need to apply patch 4 too. There's a warning in linux-next now without it.
Rob
On 15/02/2023 15:10, Rob Herring wrote:
> On Tue, Feb 14, 2023 at 11:28 AM Bjorn Andersson <[email protected]> wrote:
>>
>> On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
>>> Bindings expect (and most of DTS use) the RPM G-Link node name to be
>>> "rpm-requests".
>>>
>>>
>>
>> Applied, thanks!
>>
>> [6/7] dt-bindings: remoteproc: qcom,glink-rpm-edge: convert to DT schema
>> commit: fdafdddf7b2f5cab8d233ef97f1fad8ec7d2e7a0
>> [7/7] dt-bindings: remoteproc: qcom,glink-edge: correct label description
>> commit: 6f9c2f19a8743c880903a031c7f3f3c534d4b813
>
> You need to apply patch 4 too. There's a warning in linux-next now without it.
Bjorn, can you grab patch 4 as well?
Best regards,
Krzysztof
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
> Bindings expect (and most of DTS use) the RPM G-Link node name to be
> "rpm-requests".
>
>
Applied, thanks!
[4/7] dt-bindings: mailbox: qcom,apcs-kpss-global: drop mbox-names from example
commit: 7c855ef7137a67bcff0e039691b969428dd8ef6a
Best regards,
--
Bjorn Andersson <[email protected]>
On Wed, Feb 08, 2023 at 11:15:42AM +0100, Krzysztof Kozlowski wrote:
> Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names
> property.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
>
> Changes since v1:
> 1. None.
> 2. Previously was sent as separate patch.
>
> There are no strict dependencies. This can go anytime. The next patch
> (glink-rpm-edge) should be applied in the same or later cycle (could be
> via different trees).
Jassi, I missed this note and merged the following patches, introducing
the forecasted issue in linux-next. To remedy this, I took the liberty
of merging this patch as well into the remoteproc tree.
Regards,
Bjorn
> ---
> .../devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 943f9472ae10..56b386b688b3 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -155,7 +155,6 @@ examples:
> interrupts = <GIC_SPI 168 IRQ_TYPE_EDGE_RISING>;
> qcom,rpm-msg-ram = <&rpm_msg_ram>;
> mboxes = <&apcs_glb 0>;
> - mbox-names = "rpm_hlos";
> };
>
> # Example apcs with qcs404
> --
> 2.34.1
>
On Wed, Feb 15, 2023 at 1:19 PM Bjorn Andersson <[email protected]> wrote:
>
> On Wed, Feb 08, 2023 at 11:15:42AM +0100, Krzysztof Kozlowski wrote:
> > Qualcomm G-Link RPM edge bindings do not allow and do not use mbox-names
> > property.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
> >
> > ---
> >
> > Changes since v1:
> > 1. None.
> > 2. Previously was sent as separate patch.
> >
> > There are no strict dependencies. This can go anytime. The next patch
> > (glink-rpm-edge) should be applied in the same or later cycle (could be
> > via different trees).
>
> Jassi, I missed this note and merged the following patches, introducing
> the forecasted issue in linux-next. To remedy this, I took the liberty
> of merging this patch as well into the remoteproc tree.
>
No problem.
Cheers.
On Wed, 8 Feb 2023 11:15:39 +0100, Krzysztof Kozlowski wrote:
> Bindings expect (and most of DTS use) the RPM G-Link node name to be
> "rpm-requests".
>
>
Applied, thanks!
[5/7] dt-bindings: soc: qcom,apr: correct qcom,intents type
commit: b5bec0f00ee1c52ff0965a5dba4c91c413a6f3de
Best regards,
--
Bjorn Andersson <[email protected]>