2023-03-24 12:27:39

by Pandey, Radhey Shyam

Subject: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol

SGMII is validated on kria KR260 robotics starter kit. So modify the
comment description to include it in supported controllers list.

Signed-off-by: Radhey Shyam Pandey <[email protected]>
---
drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
index 9be9535ad7ab..ebe5ba730234 100644
--- a/drivers/phy/xilinx/phy-zynqmp.c
+++ b/drivers/phy/xilinx/phy-zynqmp.c
@@ -8,9 +8,9 @@
* Author: Subbaraya Sundeep <[email protected]>
* Author: Laurent Pinchart <[email protected]>
*
- * This driver is tested for USB, SATA and Display Port currently.
- * Other controllers PCIe and SGMII should also work but that is
- * experimental as of now.
+ * This driver is tested for USB, SGMII, SATA and Display Port currently.
+ * Other controller i.e PCIe should also work but that is experimental
+ * as of now.
*/

#include <linux/clk.h>
--
2.25.1

2023-03-24 20:45:26

by Laurent Pinchart

Subject: Re: [PATCH] phy: xilinx: phy-zynqmp: mention SGMII as supported protocol

Hi Radhey,

Thank you for the patch.

On Fri, Mar 24, 2023 at 05:54:39PM +0530, Radhey Shyam Pandey wrote:
> SGMII is validated on kria KR260 robotics starter kit. So modify the
> comment description to include it in supported controllers list.
>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> drivers/phy/xilinx/phy-zynqmp.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/phy/xilinx/phy-zynqmp.c b/drivers/phy/xilinx/phy-zynqmp.c
> index 9be9535ad7ab..ebe5ba730234 100644
> --- a/drivers/phy/xilinx/phy-zynqmp.c
> +++ b/drivers/phy/xilinx/phy-zynqmp.c
> @@ -8,9 +8,9 @@
> * Author: Subbaraya Sundeep <[email protected]>
> * Author: Laurent Pinchart <[email protected]>
> *
> - * This driver is tested for USB, SATA and Display Port currently.
> - * Other controllers PCIe and SGMII should also work but that is
> - * experimental as of now.
> + * This driver is tested for USB, SGMII, SATA and Display Port currently.
> + * Other controller i.e PCIe should also work but that is experimental

As only PCIe is left, I'd write

* PCIe should also work but that is experimental as of now.

With that,

Reviewed-by: Laurent Pinchart <[email protected]>

Of course it would be even better if you could test PCIe ;-)

> + * as of now.
> */
>
> #include <linux/clk.h>

--
Regards,

Laurent Pinchart