2023-03-20 17:37:04

by 李扬韬

Subject: [PATCH] f2fs: remove else in f2fs_write_cache_pages()

As Christoph Hellwig point out:

Please avoid the else by doing the goto in the branch.

Signed-off-by: Yangtao Li <[email protected]>
---
fs/f2fs/data.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index bf51e6e4eb64..fa931fb768e7 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -3123,12 +3123,9 @@ static int f2fs_write_cache_pages(struct address_space *mapping,
}

if (folio_test_writeback(folio)) {
- if (wbc->sync_mode != WB_SYNC_NONE)
- f2fs_wait_on_page_writeback(
- &folio->page,
- DATA, true, true);
- else
+ if (wbc->sync_mode == WB_SYNC_NONE)
goto continue_unlock;
+ f2fs_wait_on_page_writeback(&folio->page, DATA, true, true);
}

if (!folio_clear_dirty_for_io(folio))
--
2.35.1

2023-03-26 13:53:42

by Chao Yu

Subject: Re: [PATCH] f2fs: remove else in f2fs_write_cache_pages()

On 2023/3/21 1:31, Yangtao Li wrote:
> As Christoph Hellwig point out:
>
> Please avoid the else by doing the goto in the branch.
>
> Signed-off-by: Yangtao Li <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-03-27 16:02:40

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: remove else in f2fs_write_cache_pages()

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Tue, 21 Mar 2023 01:31:36 +0800 you wrote:
> As Christoph Hellwig point out:
>
> Please avoid the else by doing the goto in the branch.
>
> Signed-off-by: Yangtao Li <[email protected]>
> ---
> fs/f2fs/data.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)

Here is the summary with links:
- [f2fs-dev] f2fs: remove else in f2fs_write_cache_pages()
https://git.kernel.org/jaegeuk/f2fs/c/d2afb3f006dc

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html