2023-03-27 14:51:07

by Bjorn Andersson

[permalink] [raw]
Subject: [PATCH 0/2] rpmsg: glink: Wait for intent after intent request

When written it was assumed that upon requesting an intent, the intent
would arrive followed by an intent request acknowledgement. But this is
not always the case, in which case the current implementation would
request yet another intent and when that is acknowledged find the first
received intent - if the remote didn't run out of memory and failed the
second request...

Bjorn Andersson (2):
rpmsg: glink: Transition intent request signaling to wait queue
rpmsg: glink: Wait for intent, not just request ack

drivers/rpmsg/qcom_glink_native.c | 37 ++++++++++++++++++++++---------
1 file changed, 26 insertions(+), 11 deletions(-)

--
2.25.1


2023-04-07 22:41:04

by Chris Lew

[permalink] [raw]
Subject: Re: [PATCH 0/2] rpmsg: glink: Wait for intent after intent request



On 3/27/2023 7:46 AM, Bjorn Andersson wrote:
> When written it was assumed that upon requesting an intent, the intent
> would arrive followed by an intent request acknowledgement. But this is
> not always the case, in which case the current implementation would
> request yet another intent and when that is acknowledged find the first
> received intent - if the remote didn't run out of memory and failed the
> second request...
>
> Bjorn Andersson (2):
> rpmsg: glink: Transition intent request signaling to wait queue
> rpmsg: glink: Wait for intent, not just request ack
>
> drivers/rpmsg/qcom_glink_native.c | 37 ++++++++++++++++++++++---------
> 1 file changed, 26 insertions(+), 11 deletions(-)
>

Reviewed-by: Chris Lew <[email protected]>

2023-04-18 16:15:15

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH 0/2] rpmsg: glink: Wait for intent after intent request

On Mon, 27 Mar 2023 07:46:15 -0700, Bjorn Andersson wrote:
> When written it was assumed that upon requesting an intent, the intent
> would arrive followed by an intent request acknowledgement. But this is
> not always the case, in which case the current implementation would
> request yet another intent and when that is acknowledged find the first
> received intent - if the remote didn't run out of memory and failed the
> second request...
>
> [...]

Applied, thanks!

[1/2] rpmsg: glink: Transition intent request signaling to wait queue
commit: c09c7a59bfdd9a5d02a75ab640ed73ad56b3d1bc
[2/2] rpmsg: glink: Wait for intent, not just request ack
commit: 62efe3ed777c180a924a8576ca0b5a1a55eba9ae

Best regards,
--
Bjorn Andersson <[email protected]>