2023-04-26 18:55:44

by Justin Chen

Subject: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

The ASP 2.0 Ethernet controller uses a brcm unimac.

Signed-off-by: Florian Fainelli <[email protected]>
Signed-off-by: Justin Chen <[email protected]>
---
Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
index 0be426ee1e44..6684810fcbf0 100644
--- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
+++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
@@ -22,6 +22,8 @@ properties:
- brcm,genet-mdio-v3
- brcm,genet-mdio-v4
- brcm,genet-mdio-v5
+ - brcm,asp-v2.0-mdio
+ - brcm,asp-v2.1-mdio
- brcm,unimac-mdio

reg:
--
2.7.4

2023-04-27 17:16:03

by Rob Herring

Subject: Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote:
> The ASP 2.0 Ethernet controller uses a brcm unimac.
>
> Signed-off-by: Florian Fainelli <[email protected]>
> Signed-off-by: Justin Chen <[email protected]>
> ---
> Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> index 0be426ee1e44..6684810fcbf0 100644
> --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
> @@ -22,6 +22,8 @@ properties:
> - brcm,genet-mdio-v3
> - brcm,genet-mdio-v4
> - brcm,genet-mdio-v5
> + - brcm,asp-v2.0-mdio
> + - brcm,asp-v2.1-mdio

How many SoCs does each of these correspond to? SoC specific compatibles
are preferred to version numbers (because few vendors are disciplined
at versioning and also not changing versions with every Soc).

> - brcm,unimac-mdio
>
> reg:
> --
> 2.7.4
>

2023-04-27 17:16:28

by Florian Fainelli

Subject: Re: [PATCH v2 net-next 1/6] dt-bindings: net: brcm,unimac-mdio: Add asp-v2.0

On 4/27/23 10:03, Rob Herring wrote:
> On Wed, Apr 26, 2023 at 11:54:27AM -0700, Justin Chen wrote:
>> The ASP 2.0 Ethernet controller uses a brcm unimac.
>>
>> Signed-off-by: Florian Fainelli <[email protected]>
>> Signed-off-by: Justin Chen <[email protected]>
>> ---
>> Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> index 0be426ee1e44..6684810fcbf0 100644
>> --- a/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> +++ b/Documentation/devicetree/bindings/net/brcm,unimac-mdio.yaml
>> @@ -22,6 +22,8 @@ properties:
>> - brcm,genet-mdio-v3
>> - brcm,genet-mdio-v4
>> - brcm,genet-mdio-v5
>> + - brcm,asp-v2.0-mdio
>> + - brcm,asp-v2.1-mdio
>
> How many SoCs does each of these correspond to? SoC specific compatibles
> are preferred to version numbers (because few vendors are disciplined
> at versioning and also not changing versions with every Soc).

So far there is a 1:1 mapping between the number of versions and the
number of SoCs, and the older SoC uses v2.0, while the newer one uses v2.1.
--
Florian