2023-06-13 19:18:32

by Johannes Berg

Subject: [PATCH] gdb: linux: make SB_* constants gdb-parsed

From: Johannes Berg <[email protected]>

These now contain "UL" suffixes due to the use of BIT(),
so they need to be parsed by gdb since python doesn't
understand that.

Also fix a comment typo while at it.

ticket=none

Fixes: f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
Signed-off-by: Johannes Berg <[email protected]>
---
scripts/gdb/linux/constants.py.in | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
index 471300ba176c..646fffddd862 100644
--- a/scripts/gdb/linux/constants.py.in
+++ b/scripts/gdb/linux/constants.py.in
@@ -48,14 +48,14 @@ if IS_BUILTIN(CONFIG_COMMON_CLK):
LX_GDBPARSED(CLK_GET_RATE_NOCACHE)

/* linux/fs.h */
-LX_VALUE(SB_RDONLY)
-LX_VALUE(SB_SYNCHRONOUS)
-LX_VALUE(SB_MANDLOCK)
-LX_VALUE(SB_DIRSYNC)
-LX_VALUE(SB_NOATIME)
-LX_VALUE(SB_NODIRATIME)
+LX_GDBPARSED(SB_RDONLY)
+LX_GDBPARSED(SB_SYNCHRONOUS)
+LX_GDBPARSED(SB_MANDLOCK)
+LX_GDBPARSED(SB_DIRSYNC)
+LX_GDBPARSED(SB_NOATIME)
+LX_GDBPARSED(SB_NODIRATIME)

-/* linux/htimer.h */
+/* linux/hrtimer.h */
LX_GDBPARSED(hrtimer_resolution)

/* linux/irq.h */
--
2.40.1

2023-06-14 08:56:45

by Kieran Bingham

Subject: Re: [PATCH] gdb: linux: make SB_* constants gdb-parsed

Hi Johannes,

Quoting Johannes Berg (2023-06-13 20:11:59)
> From: Johannes Berg <[email protected]>
>
> These now contain "UL" suffixes due to the use of BIT(),
> so they need to be parsed by gdb since python doesn't
> understand that.
>
Thank you for the patch, however there is an existing patch [0] submitted
and on it's way upstream [1] to resolve this.

[0] https://lore.kernel.org/all/[email protected]/
[1] https://lore.kernel.org/all/[email protected]/

> Also fix a comment typo while at it.
>

This typo wasn't fixed though. Perhaps that's worth a separate patch if
you wish ...

--
Regards

Kieran

> ticket=none
>
> Fixes: f15afbd34d8f ("fs: fix undefined behavior in bit shift for SB_NOUSER")
> Signed-off-by: Johannes Berg <[email protected]>
> ---
> scripts/gdb/linux/constants.py.in | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in
> index 471300ba176c..646fffddd862 100644
> --- a/scripts/gdb/linux/constants.py.in
> +++ b/scripts/gdb/linux/constants.py.in
> @@ -48,14 +48,14 @@ if IS_BUILTIN(CONFIG_COMMON_CLK):
> LX_GDBPARSED(CLK_GET_RATE_NOCACHE)
>
> /* linux/fs.h */
> -LX_VALUE(SB_RDONLY)
> -LX_VALUE(SB_SYNCHRONOUS)
> -LX_VALUE(SB_MANDLOCK)
> -LX_VALUE(SB_DIRSYNC)
> -LX_VALUE(SB_NOATIME)
> -LX_VALUE(SB_NODIRATIME)
> +LX_GDBPARSED(SB_RDONLY)
> +LX_GDBPARSED(SB_SYNCHRONOUS)
> +LX_GDBPARSED(SB_MANDLOCK)
> +LX_GDBPARSED(SB_DIRSYNC)
> +LX_GDBPARSED(SB_NOATIME)
> +LX_GDBPARSED(SB_NODIRATIME)
>
> -/* linux/htimer.h */
> +/* linux/hrtimer.h */
> LX_GDBPARSED(hrtimer_resolution)
>
> /* linux/irq.h */
> --
> 2.40.1
>