2023-05-29 10:31:09

by Song Shuai

Subject: [PATCH] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle

With this configuration opened, the basic platform-independent s2idle is
provided by the sole "s2idle" string in `/sys/power/mem_sleep`.

At the end of s2idle, harts will hit the `wfi` instruction or enter the
SUSPENDED state through the sbi_cpuidle driver. The interrupt of possible
wakeup devices will be kept to wake the system up.

And platform-specific sleep states can be provided by future ACPI and
SBI SUSP extension support.

Signed-off-by: Song Shuai <[email protected]>
---
arch/riscv/Kconfig | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
index 348c0fa1fc8c..4bb818035585 100644
--- a/arch/riscv/Kconfig
+++ b/arch/riscv/Kconfig
@@ -805,6 +805,9 @@ config ARCH_HIBERNATION_POSSIBLE
config ARCH_HIBERNATION_HEADER
def_bool HIBERNATION

+config ARCH_SUSPEND_POSSIBLE
+ def_bool y
+
endmenu # "Power management options"

menu "CPU Power Management"
--
2.20.1

2023-05-29 13:22:18

by Andrew Jones

Subject: Re: [PATCH] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle

On Mon, May 29, 2023 at 06:15:24PM +0800, Song Shuai wrote:
> With this configuration opened, the basic platform-independent s2idle is
> provided by the sole "s2idle" string in `/sys/power/mem_sleep`.
>
> At the end of s2idle, harts will hit the `wfi` instruction or enter the
> SUSPENDED state through the sbi_cpuidle driver. The interrupt of possible
> wakeup devices will be kept to wake the system up.
>
> And platform-specific sleep states can be provided by future ACPI and
> SBI SUSP extension support.
>
> Signed-off-by: Song Shuai <[email protected]>
> ---
> arch/riscv/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 348c0fa1fc8c..4bb818035585 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -805,6 +805,9 @@ config ARCH_HIBERNATION_POSSIBLE
> config ARCH_HIBERNATION_HEADER
> def_bool HIBERNATION
>
> +config ARCH_SUSPEND_POSSIBLE
> + def_bool y
> +
> endmenu # "Power management options"
>
> menu "CPU Power Management"
> --
> 2.20.1
>

Reviewed-by: Andrew Jones <[email protected]>

Thanks,
drew

2023-07-05 23:45:32

by Palmer Dabbelt

Subject: Re: [PATCH] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle

On Mon, 29 May 2023 18:15:24 +0800, Song Shuai wrote:
> With this configuration opened, the basic platform-independent s2idle is
> provided by the sole "s2idle" string in `/sys/power/mem_sleep`.
>
> At the end of s2idle, harts will hit the `wfi` instruction or enter the
> SUSPENDED state through the sbi_cpuidle driver. The interrupt of possible
> wakeup devices will be kept to wake the system up.
>
> [...]

Applied, thanks!

[1/1] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle
https://git.kernel.org/palmer/c/c1f048a6bd7d

Best regards,
--
Palmer Dabbelt <[email protected]>

2023-07-05 23:53:54

by patchwork-bot+linux-riscv

Subject: Re: [PATCH] riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <[email protected]>:

On Mon, 29 May 2023 18:15:24 +0800 you wrote:
> With this configuration opened, the basic platform-independent s2idle is
> provided by the sole "s2idle" string in `/sys/power/mem_sleep`.
>
> At the end of s2idle, harts will hit the `wfi` instruction or enter the
> SUSPENDED state through the sbi_cpuidle driver. The interrupt of possible
> wakeup devices will be kept to wake the system up.
>
> [...]

Here is the summary with links:
- riscv: Enable ARCH_SUSPEND_POSSIBLE for s2idle
https://git.kernel.org/riscv/c/c1f048a6bd7d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html