2023-08-25 10:19:22

by Hongxing Zhu

[permalink] [raw]
Subject: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains

Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.

Signed-off-by: Richard Zhu <[email protected]>
---
drivers/firmware/imx/scu-pd.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
index 84b673427073..7b8c2689b49c 100644
--- a/drivers/firmware/imx/scu-pd.c
+++ b/drivers/firmware/imx/scu-pd.c
@@ -165,7 +165,10 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
{ "gpu0-pid", IMX_SC_R_GPU_0_PID0, 4, true, 0 },

/* HSIO SS */
+ { "pcie-a", IMX_SC_R_PCIE_A, 1, false, 0 },
{ "pcie-b", IMX_SC_R_PCIE_B, 1, false, 0 },
+ { "sata-0", IMX_SC_R_SATA_0, 1, false, 0 },
+ { "serdes-0", IMX_SC_R_SERDES_0, 1, false, 0 },
{ "serdes-1", IMX_SC_R_SERDES_1, 1, false, 0 },
{ "hsio-gpio", IMX_SC_R_HSIO_GPIO, 1, false, 0 },

--
2.34.1



2023-09-24 14:07:54

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains

On Fri, Aug 25, 2023 at 03:47:15PM +0800, Richard Zhu wrote:
> Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.
>
> Signed-off-by: Richard Zhu <[email protected]>

It doesn't apply to v6.6-rc. Could you rebase?

Shawn

> ---
> drivers/firmware/imx/scu-pd.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c
> index 84b673427073..7b8c2689b49c 100644
> --- a/drivers/firmware/imx/scu-pd.c
> +++ b/drivers/firmware/imx/scu-pd.c
> @@ -165,7 +165,10 @@ static const struct imx_sc_pd_range imx8qxp_scu_pd_ranges[] = {
> { "gpu0-pid", IMX_SC_R_GPU_0_PID0, 4, true, 0 },
>
> /* HSIO SS */
> + { "pcie-a", IMX_SC_R_PCIE_A, 1, false, 0 },
> { "pcie-b", IMX_SC_R_PCIE_B, 1, false, 0 },
> + { "sata-0", IMX_SC_R_SATA_0, 1, false, 0 },
> + { "serdes-0", IMX_SC_R_SERDES_0, 1, false, 0 },
> { "serdes-1", IMX_SC_R_SERDES_1, 1, false, 0 },
> { "hsio-gpio", IMX_SC_R_HSIO_GPIO, 1, false, 0 },
>
> --
> 2.34.1
>

2023-09-25 00:28:00

by Shawn Guo

[permalink] [raw]
Subject: Re: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains

On Sun, Sep 24, 2023 at 10:07 PM Shawn Guo <[email protected]> wrote:
>
> On Fri, Aug 25, 2023 at 03:47:15PM +0800, Richard Zhu wrote:
> > Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.
> >
> > Signed-off-by: Richard Zhu <[email protected]>
>
> It doesn't apply to v6.6-rc. Could you rebase?

To be clear, my branch is built on v6.6-rc1, so please rebase against
that, thanks!

Shawn

2023-09-25 04:27:09

by Hongxing Zhu

[permalink] [raw]
Subject: RE: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and SERDES0 power domains

Hi Shawn:
Sorry to reply late.

> -----Original Message-----
> From: Shawn Guo <[email protected]>
> Sent: 2023年9月25日 8:24
> To: Hongxing Zhu <[email protected]>
> Cc: [email protected]; [email protected]; Marcel Ziswiler
> <[email protected]>; Frank Li <[email protected]>; Clark Wang
> <[email protected]>; [email protected];
> [email protected]; [email protected]; dl-linux-imx
> <[email protected]>
> Subject: Re: [PATCH v1] firmware: imx: scu-pd: Add missed PCIEA SATA0 and
> SERDES0 power domains
>
> On Sun, Sep 24, 2023 at 10:07 PM Shawn Guo <[email protected]> wrote:
> >
> > On Fri, Aug 25, 2023 at 03:47:15PM +0800, Richard Zhu wrote:
> > > Add missed PCIEA, SATA0 and SERDES0 power domains for HSIO SS.
> > >
> > > Signed-off-by: Richard Zhu <[email protected]>
> >
> > It doesn't apply to v6.6-rc. Could you rebase?
>
> To be clear, my branch is built on v6.6-rc1, so please rebase against that, thanks!

These changes had been merged by the following commit issued by Fan peng in
another topic.
Please ignore this patch.

commit a67d780720ff406943d56286bc06aa60c2b59d3a
Author: Peng Fan <[email protected]>
Date: Mon Aug 14 18:41:22 2023 +0800

genpd: imx: scu-pd: add more PDs

Add more PDs for i.MX8QM and i.MX8DXL, including
dma-ch, esai, gpu1, v2x-mu, seco-mu, hdmi, img and etc.

Signed-off-by: Peng Fan <[email protected]>
Signed-off-by: Ulf Hansson <[email protected]>

diff --git a/drivers/genpd/imx/scu-pd.c b/drivers/genpd/imx/scu-pd.c
index 5a28f5af592a..08583a10ac62 100644
--- a/drivers/genpd/imx/scu-pd.c
+++ b/drivers/genpd/imx/scu-pd.c

Best Regards
Richard Zhu

>
> Shawn