September 19, 2023 at 1:15 PM, "Thomas Weißschuh" <[email protected]> wrote:
> On 2023-09-18 12:05:19-0700, Guenter Roeck wrote:
>
> >
> > On Mon, Sep 11, 2023 at 07:44:42AM +0200, Thomas Weißschuh wrote:
> > The KM002C is similar to the KM003C and seems to use the same
> > protocol and firmware.
> >
> > Reported-by: Douglas Gilbert <[email protected]>
> > Closes: https://lore.kernel.org/lkml/[email protected]/
> > Signed-off-by: Thomas Weißschuh <[email protected]>
> > ---
> >
> > This patch is based on hwmon-next,
> > commit 80369d9e1f2f ("hwmon: (sch5627) Document behaviour of limit registers").
> >
> > Signed-off-by: Thomas Weißschuh <[email protected]>
> >
> > Applied, but please be more careful with your comments and Signed-off-by:
> > tags. There should only be one '---', and one signature.
> >
>
> Thanks,
>
> the duplicate Signed-off-by is indeed an oversight which I'll
> try to avoid in the future.
>
> As for the '---':
>
> Two of them are generated by the 'b4' tool and I added one manually with
> the hwmon-next information.
> For other subsystems this wasn't an issue so far.
>
> Are these duplicate sections a problem for your personal tooling or is
> it affecting something more widespread?
There should be no impact on any tooling, to my knowledge. Only the first --- matters for git, any additional ones are ignored.
-K