On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote:
> When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
> sent out on October 11th,, there was still a call to
> platform_set_drvdata() which would ensure that the driver private data
> structure could be used in bcm2835_pwm_{suspend,resume}.
>
> A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
> Simplify using devm functions") removed that call which would now cause
> a NPD in bcm2835_pwm_{suspend,resume} as a consequence.
>
> [...]
Applied, thanks!
[1/1] pwm: bcm2835: Fix NPD in suspend/resume
commit: fba7e9f839d7fcb0888094697da45c5668226455
Best regards,
--
Thierry Reding <[email protected]>
On Tue, Nov 28, 2023 at 06:49:22PM +0100, Thierry Reding wrote:
>
> On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote:
> > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
> > sent out on October 11th,, there was still a call to
> > platform_set_drvdata() which would ensure that the driver private data
> > structure could be used in bcm2835_pwm_{suspend,resume}.
> >
> > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
> > Simplify using devm functions") removed that call which would now cause
> > a NPD in bcm2835_pwm_{suspend,resume} as a consequence.
> >
> > [...]
>
> Applied, thanks!
>
> [1/1] pwm: bcm2835: Fix NPD in suspend/resume
> commit: fba7e9f839d7fcb0888094697da45c5668226455
This one should IMHO go into v6.7. Do you intend to send it to Linus
during the current cycle?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Hello Thierry,
On Tue, Nov 28, 2023 at 09:55:48PM +0100, Uwe Kleine-K?nig wrote:
> On Tue, Nov 28, 2023 at 06:49:22PM +0100, Thierry Reding wrote:
> >
> > On Mon, 13 Nov 2023 08:46:32 -0800, Florian Fainelli wrote:
> > > When 119a508c4dc9 ("pwm: bcm2835: Add support for suspend/resume") was
> > > sent out on October 11th,, there was still a call to
> > > platform_set_drvdata() which would ensure that the driver private data
> > > structure could be used in bcm2835_pwm_{suspend,resume}.
> > >
> > > A cleanup now merged as commit commit 2ce7b7f6704c ("pwm: bcm2835:
> > > Simplify using devm functions") removed that call which would now cause
> > > a NPD in bcm2835_pwm_{suspend,resume} as a consequence.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/1] pwm: bcm2835: Fix NPD in suspend/resume
> > commit: fba7e9f839d7fcb0888094697da45c5668226455
>
> This one should IMHO go into v6.7. Do you intend to send it to Linus
> during the current cycle?
We know since > 2 weeks now that the pwm-bcm2835 driver is broken in
v6.7-rc1 and there is a fix since day 0.
If you continue to be silent about this (here and at
https://lore.kernel.org/linux-pwm/[email protected])
I intend to send a PR to Linus with this fix on Friday next week.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |