2023-11-27 14:42:02

by Haoran Liu

Subject: [PATCH] powerpc/powernv: Add error handling to opal_prd_range_is_valid

In the opal_prd_range_is_valid function within opal-prd.c,
error handling was missing for the of_get_address call.
This patch adds necessary error checking, ensuring that the
function gracefully handles scenarios where of_get_address fails.

Signed-off-by: Haoran Liu <[email protected]>
---
arch/powerpc/platforms/powernv/opal-prd.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/opal-prd.c b/arch/powerpc/platforms/powernv/opal-prd.c
index 327e2f76905d..b66b06efcef1 100644
--- a/arch/powerpc/platforms/powernv/opal-prd.c
+++ b/arch/powerpc/platforms/powernv/opal-prd.c
@@ -66,6 +66,8 @@ static bool opal_prd_range_is_valid(uint64_t addr, uint64_t size)
const char *label;

addrp = of_get_address(node, 0, &range_size, NULL);
+ if (!addrp)
+ continue;

range_addr = of_read_number(addrp, 2);
range_end = range_addr + range_size;
--
2.17.1

2023-12-31 11:08:48

by Michael Ellerman

Subject: Re: [PATCH] powerpc/powernv: Add error handling to opal_prd_range_is_valid

On Mon, 27 Nov 2023 06:41:08 -0800, Haoran Liu wrote:
> In the opal_prd_range_is_valid function within opal-prd.c,
> error handling was missing for the of_get_address call.
> This patch adds necessary error checking, ensuring that the
> function gracefully handles scenarios where of_get_address fails.
>
>

Applied to powerpc/next.

[1/1] powerpc/powernv: Add error handling to opal_prd_range_is_valid
https://git.kernel.org/powerpc/c/e6beb47edb89ca9dc8906515e2dfbeb5913312c8

cheers