devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.
Cc: Kunwu Chan <[email protected]>
Signed-off-by: Kunwu Chan <[email protected]>
Suggested-by: Jakub Kicinski <[email protected]>
---
v2: Remove error print
---
drivers/net/dsa/vitesse-vsc73xx-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/dsa/vitesse-vsc73xx-core.c b/drivers/net/dsa/vitesse-vsc73xx-core.c
index e6f29e4e508c..571f037fe649 100644
--- a/drivers/net/dsa/vitesse-vsc73xx-core.c
+++ b/drivers/net/dsa/vitesse-vsc73xx-core.c
@@ -1135,6 +1135,8 @@ static int vsc73xx_gpio_probe(struct vsc73xx *vsc)
vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x",
vsc->chipid);
+ if (!vsc->gc.label)
+ return -ENOMEM;
vsc->gc.ngpio = 4;
vsc->gc.owner = THIS_MODULE;
vsc->gc.parent = vsc->dev;
--
2.39.2
On Thu, Jan 11, 2024 at 03:20:18PM +0800, Kunwu Chan wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
> Cc: Kunwu Chan <[email protected]>
> Signed-off-by: Kunwu Chan <[email protected]>
> Suggested-by: Jakub Kicinski <[email protected]>
Hi Kunwu,
This seems to be a bug fix. If so it should have a fixes tag.
Perhaps this one is correct?
Fixes: 05bd97fc559d ("net: dsa: Add Vitesse VSC73xx DSA router driver")
And, be targeted against net (as opposed to net-next)
Subject: [PATCH net v2] ...
It is probably not necessary to repost to address these minor issues,
but please keep this in mind in future.
The above notwithstanding,
Reviewed-by: Simon Horman <[email protected]>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <[email protected]>:
On Thu, 11 Jan 2024 15:20:18 +0800 you wrote:
> devm_kasprintf() returns a pointer to dynamically allocated memory
> which can be NULL upon failure.
>
> Cc: Kunwu Chan <[email protected]>
> Signed-off-by: Kunwu Chan <[email protected]>
> Suggested-by: Jakub Kicinski <[email protected]>
>
> [...]
Here is the summary with links:
- [v2] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe
https://git.kernel.org/netdev/net/c/776dac5a6627
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html