2023-12-29 03:15:14

by Wu Bo

Subject: [PATCH] f2fs: check free sections before disable checkpoint

'f2fs_is_checkpoint_ready()' checks free sections. If there is not
enough free sections, most f2fs operations will return -ENOSPC when
checkpoint is disabled.

It would be better to check free sections before disable checkpoint.

Signed-off-by: Wu Bo <[email protected]>
---
fs/f2fs/segment.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index 727d016318f9..8f8c0bb75be1 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -906,6 +906,8 @@ int f2fs_disable_cp_again(struct f2fs_sb_info *sbi, block_t unusable)
if (is_sbi_flag_set(sbi, SBI_CP_DISABLED_QUICK) &&
dirty_segments(sbi) > ovp_hole_segs)
return -EAGAIN;
+ if (has_not_enough_free_secs(sbi, 0, 0))
+ return -EAGAIN;
return 0;
}

--
2.25.1

2024-01-12 01:20:39

by Chao Yu

Subject: Re: [PATCH] f2fs: check free sections before disable checkpoint

On 2023/12/29 11:25, Wu Bo wrote:
> 'f2fs_is_checkpoint_ready()' checks free sections. If there is not
> enough free sections, most f2fs operations will return -ENOSPC when
> checkpoint is disabled.
>
> It would be better to check free sections before disable checkpoint.
>
> Signed-off-by: Wu Bo <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2024-01-29 20:34:35

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: check free sections before disable checkpoint

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Thu, 28 Dec 2023 20:25:07 -0700 you wrote:
> 'f2fs_is_checkpoint_ready()' checks free sections. If there is not
> enough free sections, most f2fs operations will return -ENOSPC when
> checkpoint is disabled.
>
> It would be better to check free sections before disable checkpoint.
>
> Signed-off-by: Wu Bo <[email protected]>
>
> [...]

Here is the summary with links:
- [f2fs-dev] f2fs: check free sections before disable checkpoint
https://git.kernel.org/jaegeuk/f2fs/c/e2f29120ff1f

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html