2024-02-01 05:43:16

by Jason Wang

[permalink] [raw]
Subject: Re: [PATCH v4] virtio_net: Support RX hash XDP hint

On Wed, Jan 31, 2024 at 11:55 AM Liang Chen <[email protected]> wrote:
>
> The RSS hash report is a feature that's part of the virtio specification.
> Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
> (still a work in progress as per [1]) support this feature. While the
> capability to obtain the RSS hash has been enabled in the normal path,
> it's currently missing in the XDP path. Therefore, we are introducing
> XDP hints through kfuncs to allow XDP programs to access the RSS hash.
>
> 1.
> https://lore.kernel.org/all/[email protected]/#r
>
> Signed-off-by: Liang Chen <[email protected]>
> Reviewed-by: Xuan Zhuo <[email protected]>

Acked-by: Jason Wang <[email protected]>

Thanks



2024-02-02 09:34:49

by Liang Chen

[permalink] [raw]
Subject: Re: [PATCH v4] virtio_net: Support RX hash XDP hint

On Thu, Feb 1, 2024 at 1:37 PM Jason Wang <[email protected]> wrote:
>
> On Wed, Jan 31, 2024 at 11:55 AM Liang Chen <[email protected]> wrote:
> >
> > The RSS hash report is a feature that's part of the virtio specification.
> > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
> > (still a work in progress as per [1]) support this feature. While the
> > capability to obtain the RSS hash has been enabled in the normal path,
> > it's currently missing in the XDP path. Therefore, we are introducing
> > XDP hints through kfuncs to allow XDP programs to access the RSS hash.
> >
> > 1.
> > https://lore.kernel.org/all/[email protected]/#r
> >
> > Signed-off-by: Liang Chen <[email protected]>
> > Reviewed-by: Xuan Zhuo <[email protected]>
>
> Acked-by: Jason Wang <[email protected]>
>
> Thanks

I've just realized that I forgot to include [email protected] in
the cc list. Would it be advisable for me to resend the patch with
[email protected] in the cc list to ensure it receives the
necessary attention for potential merging? Thanks!

Thanks,
Liang
>

2024-02-02 10:22:27

by Xuan Zhuo

[permalink] [raw]
Subject: Re: [PATCH v4] virtio_net: Support RX hash XDP hint

On Fri, 2 Feb 2024 17:25:02 +0800, Liang Chen <[email protected]> wrote:
> On Thu, Feb 1, 2024 at 1:37 PM Jason Wang <[email protected]> wrote:
> >
> > On Wed, Jan 31, 2024 at 11:55 AM Liang Chen <[email protected]> wrote:
> > >
> > > The RSS hash report is a feature that's part of the virtio specification.
> > > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
> > > (still a work in progress as per [1]) support this feature. While the
> > > capability to obtain the RSS hash has been enabled in the normal path,
> > > it's currently missing in the XDP path. Therefore, we are introducing
> > > XDP hints through kfuncs to allow XDP programs to access the RSS hash.
> > >
> > > 1.
> > > https://lore.kernel.org/all/[email protected]/#r
> > >
> > > Signed-off-by: Liang Chen <[email protected]>
> > > Reviewed-by: Xuan Zhuo <[email protected]>
> >
> > Acked-by: Jason Wang <[email protected]>
> >
> > Thanks
>
> I've just realized that I forgot to include [email protected] in
> the cc list. Would it be advisable for me to resend the patch with
> [email protected] in the cc list to ensure it receives the
> necessary attention for potential merging? Thanks!

Did you use ./scripts/get_maintainer.pl?

Please resend it.

Thanks.


>
> Thanks,
> Liang
> >

2024-02-02 11:29:54

by Liang Chen

[permalink] [raw]
Subject: Re: [PATCH v4] virtio_net: Support RX hash XDP hint

On Fri, Feb 2, 2024 at 5:58 PM Xuan Zhuo <[email protected]> wrote:
>
> On Fri, 2 Feb 2024 17:25:02 +0800, Liang Chen <[email protected]> wrote:
> > On Thu, Feb 1, 2024 at 1:37 PM Jason Wang <[email protected]> wrote:
> > >
> > > On Wed, Jan 31, 2024 at 11:55 AM Liang Chen <[email protected]> wrote:
> > > >
> > > > The RSS hash report is a feature that's part of the virtio specification.
> > > > Currently, virtio backends like qemu, vdpa (mlx5), and potentially vhost
> > > > (still a work in progress as per [1]) support this feature. While the
> > > > capability to obtain the RSS hash has been enabled in the normal path,
> > > > it's currently missing in the XDP path. Therefore, we are introducing
> > > > XDP hints through kfuncs to allow XDP programs to access the RSS hash.
> > > >
> > > > 1.
> > > > https://lore.kernel.org/all/[email protected]/#r
> > > >
> > > > Signed-off-by: Liang Chen <[email protected]>
> > > > Reviewed-by: Xuan Zhuo <[email protected]>
> > >
> > > Acked-by: Jason Wang <[email protected]>
> > >
> > > Thanks
> >
> > I've just realized that I forgot to include [email protected] in
> > the cc list. Would it be advisable for me to resend the patch with
> > [email protected] in the cc list to ensure it receives the
> > necessary attention for potential merging? Thanks!
>
> Did you use ./scripts/get_maintainer.pl?
>
> Please resend it.
>
> Thanks.
>

Sure. Thanks!

>
> >
> > Thanks,
> > Liang
> > >