2024-01-23 08:13:18

by Tang Yizhou

Subject: [PATCH] blk-throttle: Eliminate redundant checks for data direction

From: Tang Yizhou <[email protected]>

After calling throtl_peek_queued(), the data direction can be determined so
there is no need to call bio_data_dir() to check the direction again.

Signed-off-by: Tang Yizhou <[email protected]>
---
block/blk-throttle.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/block/blk-throttle.c b/block/blk-throttle.c
index 16f5766620a4..2ad4f6cd465b 100644
--- a/block/blk-throttle.c
+++ b/block/blk-throttle.c
@@ -1098,7 +1098,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg)
while ((bio = throtl_peek_queued(&sq->queued[READ])) &&
tg_may_dispatch(tg, bio, NULL)) {

- tg_dispatch_one_bio(tg, bio_data_dir(bio));
+ tg_dispatch_one_bio(tg, READ);
nr_reads++;

if (nr_reads >= max_nr_reads)
@@ -1108,7 +1108,7 @@ static int throtl_dispatch_tg(struct throtl_grp *tg)
while ((bio = throtl_peek_queued(&sq->queued[WRITE])) &&
tg_may_dispatch(tg, bio, NULL)) {

- tg_dispatch_one_bio(tg, bio_data_dir(bio));
+ tg_dispatch_one_bio(tg, WRITE);
nr_writes++;

if (nr_writes >= max_nr_writes)
--
2.25.1

2024-01-23 16:38:17

by Christoph Hellwig

Subject: Re: [PATCH] blk-throttle: Eliminate redundant checks for data direction

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2024-02-05 17:16:40

by Jens Axboe

Subject: Re: [PATCH] blk-throttle: Eliminate redundant checks for data direction

On Tue, 23 Jan 2024 16:12:48 +0800, Tang Yizhou wrote:
> After calling throtl_peek_queued(), the data direction can be determined so
> there is no need to call bio_data_dir() to check the direction again.
>
>

Applied, thanks!

[1/1] blk-throttle: Eliminate redundant checks for data direction
commit: 3bca7640b4c50621b94365a1746f4b86116fec56

Best regards,
--
Jens Axboe