2024-02-05 10:31:24

by Amit Cohen

Subject: [PATCH net-next] net: Do not return value from init_dummy_netdev()

init_dummy_netdev() always returns zero and all the callers do not check
the returned value. Set the function to not return value, as it is not
really used today.

Signed-off-by: Amit Cohen <[email protected]>
Reviewed-by: Ido Schimmel <[email protected]>
Reviewed-by: Jiri Pirko <[email protected]>
---
include/linux/netdevice.h | 2 +-
net/core/dev.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index e87caa81f70c..c2b7083d3097 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -3161,7 +3161,7 @@ static inline void unregister_netdevice(struct net_device *dev)
int netdev_refcnt_read(const struct net_device *dev);
void free_netdev(struct net_device *dev);
void netdev_freemem(struct net_device *dev);
-int init_dummy_netdev(struct net_device *dev);
+void init_dummy_netdev(struct net_device *dev);

struct net_device *netdev_get_xmit_slave(struct net_device *dev,
struct sk_buff *skb,
diff --git a/net/core/dev.c b/net/core/dev.c
index 3950ced396b5..f64961f92ba1 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -10294,7 +10294,7 @@ EXPORT_SYMBOL(register_netdevice);
* that need to tie several hardware interfaces to a single NAPI
* poll scheduler due to HW limitations.
*/
-int init_dummy_netdev(struct net_device *dev)
+void init_dummy_netdev(struct net_device *dev)
{
/* Clear everything. Note we don't initialize spinlocks
* are they aren't supposed to be taken by any of the
@@ -10322,8 +10322,6 @@ int init_dummy_netdev(struct net_device *dev)
* because users of this 'device' dont need to change
* its refcount.
*/
-
- return 0;
}
EXPORT_SYMBOL_GPL(init_dummy_netdev);

--
2.43.0

2024-02-06 20:48:09

by Simon Horman

Subject: Re: [PATCH net-next] net: Do not return value from init_dummy_netdev()

On Mon, Feb 05, 2024 at 12:30:22PM +0200, Amit Cohen wrote:
> init_dummy_netdev() always returns zero and all the callers do not check
> the returned value. Set the function to not return value, as it is not
> really used today.
>
> Signed-off-by: Amit Cohen <[email protected]>
> Reviewed-by: Ido Schimmel <[email protected]>
> Reviewed-by: Jiri Pirko <[email protected]>

Reviewed-by: Simon Horman <[email protected]>

2024-02-07 17:51:53

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: Do not return value from init_dummy_netdev()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <[email protected]>:

On Mon, 5 Feb 2024 12:30:22 +0200 you wrote:
> init_dummy_netdev() always returns zero and all the callers do not check
> the returned value. Set the function to not return value, as it is not
> really used today.
>
> Signed-off-by: Amit Cohen <[email protected]>
> Reviewed-by: Ido Schimmel <[email protected]>
> Reviewed-by: Jiri Pirko <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next] net: Do not return value from init_dummy_netdev()
https://git.kernel.org/netdev/net-next/c/d160c66cda0a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html