2024-02-20 03:48:59

by Anshuman Khandual

[permalink] [raw]
Subject: [PATCH V2] arm64/sysreg: Update ID_AA64DFR0_EL1 register

This updates ID_AA64DFR0_EL1.PMSVer and ID_AA64DFR0_EL1.DebugVer register
fields as per the definitions based on DDI0601 2023-12.

Cc: Catalin Marinas <[email protected]>
Cc: Will Deacon <[email protected]>
Cc: Mark Brown <[email protected]>
Cc: [email protected]
Cc: [email protected]
Signed-off-by: Anshuman Khandual <[email protected]>
---
This applies on v6.8-rc5

Changes in V2:

- Split ID_AA64DFR0_EL1 changes in this patch and updated PMSVer per Mark

Changes in V1:

https://lore.kernel.org/all/[email protected]/

arch/arm64/tools/sysreg | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/arm64/tools/sysreg b/arch/arm64/tools/sysreg
index a9cab2b730a3..508224a0e078 100644
--- a/arch/arm64/tools/sysreg
+++ b/arch/arm64/tools/sysreg
@@ -1223,6 +1223,7 @@ UnsignedEnum 35:32 PMSVer
0b0010 V1P1
0b0011 V1P2
0b0100 V1P3
+ 0b0101 V1P4
EndEnum
Field 31:28 CTX_CMPs
Res0 27:24
@@ -1249,6 +1250,7 @@ UnsignedEnum 3:0 DebugVer
0b1000 V8P2
0b1001 V8P4
0b1010 V8P8
+ 0b1011 V8P9
EndEnum
EndSysreg

--
2.25.1



2024-02-20 15:13:49

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH V2] arm64/sysreg: Update ID_AA64DFR0_EL1 register

On Tue, Feb 20, 2024 at 09:18:29AM +0530, Anshuman Khandual wrote:
> This updates ID_AA64DFR0_EL1.PMSVer and ID_AA64DFR0_EL1.DebugVer register
> fields as per the definitions based on DDI0601 2023-12.

Reviewed-by: Mark Brown <[email protected]>

> @@ -1223,6 +1223,7 @@ UnsignedEnum 35:32 PMSVer
> 0b0010 V1P1
> 0b0011 V1P2
> 0b0100 V1P3
> + 0b0101 V1P4
> EndEnum

There's also a FEAT_SPE_SME documented in the text but not in the table
of enumerated values (I've reported this) - it makes sense to me to skip
this until the XML is internally consistent.

> Field 31:28 CTX_CMPs
> Res0 27:24
> @@ -1249,6 +1250,7 @@ UnsignedEnum 3:0 DebugVer
> 0b1000 V8P2
> 0b1001 V8P4
> 0b1010 V8P8
> + 0b1011 V8P9
> EndEnum

There's an IMPDEF value defined for this like the 32 bit equivalent but
that was a preexisting issue.

Attachments:
(No filename) (859.00 B)
 signature.asc (499.00 B)
 Download all attachments

2024-02-21 18:37:00

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH V2] arm64/sysreg: Update ID_AA64DFR0_EL1 register

On Tue, 20 Feb 2024 09:18:29 +0530, Anshuman Khandual wrote:
> This updates ID_AA64DFR0_EL1.PMSVer and ID_AA64DFR0_EL1.DebugVer register
> fields as per the definitions based on DDI0601 2023-12.
>
>

Applied to arm64 (for-next/sysreg), thanks!

[1/1] arm64/sysreg: Update ID_AA64DFR0_EL1 register
https://git.kernel.org/arm64/c/358fee291705

--
Catalin