2024-02-28 23:17:23

by Andy Shevchenko

Subject: [PATCH v4 1/8] overflow: Use POD in check_shl_overflow()

The check_shl_overflow() uses u64 type that is defined in types.h.
Instead of including that header, just switch to use POD type
directly.

Signed-off-by: Andy Shevchenko <[email protected]>
---
include/linux/overflow.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/overflow.h b/include/linux/overflow.h
index dede374832c9..bc390f026128 100644
--- a/include/linux/overflow.h
+++ b/include/linux/overflow.h
@@ -197,7 +197,7 @@ static inline bool __must_check __must_check_overflow(bool overflow)
typeof(a) _a = a; \
typeof(s) _s = s; \
typeof(d) _d = d; \
- u64 _a_full = _a; \
+ unsigned long long _a_full = _a; \
unsigned int _to_shift = \
is_non_negative(_s) && _s < 8 * sizeof(*d) ? _s : 0; \
*_d = (_a_full << _to_shift); \
--
2.43.0.rc1.1.gbec44491f096

2024-02-29 18:50:28

by Kees Cook

Subject: Re: (subset) [PATCH v4 1/8] overflow: Use POD in check_shl_overflow()

On Wed, 28 Feb 2024 22:41:31 +0200, Andy Shevchenko wrote:
> The check_shl_overflow() uses u64 type that is defined in types.h.
> Instead of including that header, just switch to use POD type
> directly.
>
>

Applied to for-next/hardening, thanks!

[1/8] overflow: Use POD in check_shl_overflow()
https://git.kernel.org/kees/c/4e55a75495b7

Take care,

--
Kees Cook