2024-03-05 01:24:29

by Tommy Huang

Subject: [PATCH v2] i2c: aspeed: Fix the dummy irq expected print

When the i2c error condition occurred and master state was not
idle, the master irq function will goto complete state without any
other interrupt handling. It would cause dummy irq expected print.
Under this condition, assign the irq_status into irq_handle.

For example, when the abnormal start / stop occurred (bit 5) with
normal stop status (bit 4) at same time. Then the normal stop status
would not be handled and it would cause irq expected print in
the aspeed_i2c_bus_irq.

..
aspeed-i2c-bus x. i2c-bus: irq handled != irq.
Expected 0x00000030, but was 0x00000020
..

Fixes: 3e9efc3299dd ("i2c: aspeed: Handle master/slave combined irq events properly")
Cc: Jae Hyun Yoo <[email protected]>

Signed-off-by: Tommy Huang <[email protected]>
---
drivers/i2c/busses/i2c-aspeed.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/i2c/busses/i2c-aspeed.c b/drivers/i2c/busses/i2c-aspeed.c
index 5511fd46a65e..ce8c4846b7fa 100644
--- a/drivers/i2c/busses/i2c-aspeed.c
+++ b/drivers/i2c/busses/i2c-aspeed.c
@@ -445,6 +445,7 @@ static u32 aspeed_i2c_master_irq(struct aspeed_i2c_bus *bus, u32 irq_status)
irq_status);
irq_handled |= (irq_status & ASPEED_I2CD_INTR_MASTER_ERRORS);
if (bus->master_state != ASPEED_I2C_MASTER_INACTIVE) {
+ irq_handled = irq_status;
bus->cmd_err = ret;
bus->master_state = ASPEED_I2C_MASTER_INACTIVE;
goto out_complete;
--
2.25.1

2024-03-06 14:23:15

by Andi Shyti

Subject: Re: [PATCH v2] i2c: aspeed: Fix the dummy irq expected print

Hi

On Tue, 05 Mar 2024 09:19:06 +0800, Tommy Huang wrote:
> When the i2c error condition occurred and master state was not
> idle, the master irq function will goto complete state without any
> other interrupt handling. It would cause dummy irq expected print.
> Under this condition, assign the irq_status into irq_handle.
>
> For example, when the abnormal start / stop occurred (bit 5) with
> normal stop status (bit 4) at same time. Then the normal stop status
> would not be handled and it would cause irq expected print in
> the aspeed_i2c_bus_irq.
>
> [...]

Applied to i2c/i2c-host-fixes on

git://git.kernel.org/pub/scm/linux/kernel/git/andi.shyti/linux.git

Thank you,
Andi

Patches applied
===============
[1/1] i2c: aspeed: Fix the dummy irq expected print
commit: 94e889260a5bae7d4c06de90f1724aeb8b1175c6